Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24270] iOS: Fix autorelease-crash when using kroll-thread #8727

Closed
wants to merge 1 commit into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
Copy link
Collaborator Author

@vijaysingh-axway I'm not feeling save with the retain + autorelease solution so far, although it seem to work fine in all my use-cases. I'd love your opinion on this. The retain-cycle of the media property is a bit complicated (through different threads and contexts).

@vijaysingh-axway
Copy link
Contributor

@hansemannn I was thinking something of using autorelease pool and retaining the image inside caller function, but I am not very sure. Let me think in more detail on this and will let you know.

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While verifying with-
//#define TI_USE_KROLL_THREAD
#define USE_JSCORE_FRAMEWORK
I am getting memory leak .

@hansemannn Are you sure this solution is working fine .

@hansemannn
Copy link
Collaborator Author

I begin to think that the image is not really the problem, but the TiBlob is. Otherwise the issue would happen on both JSCore and TiCore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants