Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24288] iOS/Android: Deprecate "onStopBlacklistedUrl" WebView event in favor of cross-platform "blacklisturl" event #8736

Merged
merged 4 commits into from Feb 8, 2017
Merged

[TIMOB-24288] iOS/Android: Deprecate "onStopBlacklistedUrl" WebView event in favor of cross-platform "blacklisturl" event #8736

merged 4 commits into from Feb 8, 2017

Conversation

hansemannn
Copy link
Collaborator

vijaysingh-axway
vijaysingh-axway reviewed Jan 10, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment •
edited by hansemannn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 +    since: 5.4.0
 +    properties:
 +      - name: url
 +        summary: The URL of the web document that is stopped.
 +    deprecated:
 +        since: "6.1.0"
 +        notes: Use the  cross-platform `blacklist` event instead.

'blacklist' should be 'blacklisturl' .

@hansemannn
Copy link
Collaborator Author

Good catch! Updated.

@hansemannn hansemannn added this to the 6.1.0 milestone Jan 10, 2017
@garymathews
Copy link
Contributor

LGTM 👍

@hansemannn hansemannn requested review from htbryant94 and removed request for ewieberappc January 23, 2017 15:59
@hansemannn
Copy link
Collaborator Author

@htbryant94 Ping!

@lokeshchdhry lokeshchdhry requested review from lokeshchdhry and removed request for htbryant94 February 8, 2017 19:46
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 8, 2017 •
edited

FR passed.
Works as expected on both android & IOS. The blacklisturl event is fired successfully when a url is blocked.

Appc Studio : 4.8.1.201612050850
SDK Version : Locally built 6.1.0
Mac OS Version : 10.12.2
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.9-1","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0
Nexus 6 running 6.0.1

@lokeshchdhry lokeshchdhry merged commit 48c8c29 into tidev:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway left review comments

@garymathews garymathews Awaiting requested review from garymathews

@lokeshchdhry lokeshchdhry Awaiting requested review from lokeshchdhry

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @garymathews @lokeshchdhry @vijaysingh-axway