Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24233] Android: stacked background drawable parity #8740

Merged
merged 2 commits into from Jan 24, 2017

Conversation

frankieandone
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24233

Test Case
Should see same thing on iOS

var win1 = Ti.UI.createWindow({
	backgroundColor: 'blue',
	title: 'Blue'
});
win1.add(Ti.UI.createLabel({text: 'I am a blue window.'}));

var win2 = Ti.UI.createWindow({
	backgroundColor: 'red',
	title: 'Red'
});
win2.add(Ti.UI.createLabel({text: 'I am a red window.'}));

var tab1 = Ti.UI.createTab({
			window: win1,
			title: 'Blue'
		}),
		tab2 = Ti.UI.createTab({
			window: win2,
			title: 'Red'
		});

var group = Ti.UI.createTabGroup({
	tabs: [tab1, tab2],
	tabsBackgroundColor: 'green'
});

group.open();

@garymathews
Copy link
Contributor

CR: PASS
FT: PASS

@lokeshchdhry
Copy link
Contributor

@fmerzadyan @garymathews, in landscape mode I do not see the color when tabsBackgroundColor is set. Is this expected?

screen shot 2017-01-19 at 1 36 55 pm

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Jan 24, 2017

Changes looks good for both classic & alloy projects.
tabsBackgroundColor works in landscape mode as well.

@lokeshchdhry lokeshchdhry merged commit d248871 into tidev:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants