Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24317] Android: Focus area for view pinch event #8757

Merged
merged 8 commits into from Jun 28, 2018

Conversation

HazemKhaled
Copy link
Contributor

@HazemKhaled HazemKhaled commented Jan 17, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-24317

EDIT by Hans: no tests, because only testable by pinching with the actual finger, so a manual test is required.

@build
Copy link
Contributor

build commented Jan 17, 2017

Can one of the admins verify this patch?

summary: |
true if a scale gesture is in progress.
Note: This property is only available for Android
type: Number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all docs here, please add:

since: "6.2.0"
platforms: [android]

And remove the Note: This property is only available for Android after that. Also make sure to break the lines when they're getting too long. Check the existing docs for reference.

@hansemannn
Copy link
Collaborator

iOS Parity available for (some of) the properties?

@hansemannn
Copy link
Collaborator

Another thing I notices aside from this PR: The docs say that the "pinch" gesture is only available on iOS (since 1.8.0), but obviously it's available on Android as well. Do you know since when? I' git-blame-check it otherwiese

@HazemKhaled
Copy link
Contributor Author

As usual you faster, thanks for updating docs, don't have a plan to implement it with iOS.

@HazemKhaled HazemKhaled changed the title focus area for view pinch event [TIMOB-24317] Focus area for view pinch event Jan 17, 2017
@hansemannn hansemannn changed the title [TIMOB-24317] Focus area for view pinch event [TIMOB-24317] Android: Focus area for view pinch event Jan 18, 2017
@hansemannn hansemannn added this to the 7.4.0 milestone Jun 28, 2018
@hansemannn
Copy link
Collaborator

Hey @HazemKhaled, I'd like to integrate this today! Can you please do me a huge favor and sign the CLA again? We moved to a unified Axway CLA server recently that requires to re-sign once. Thank you!

@HazemKhaled
Copy link
Contributor Author

From where i can sign the new one?

@hansemannn
Copy link
Collaborator

It is here, linked via the "Details" button right to the CLA status. May be hard to find indeed :-).

@HazemKhaled
Copy link
Contributor Author

Done (Y)

@build build added the docs label Jun 28, 2018
@build
Copy link
Contributor

build commented Jun 28, 2018

Messages
📖

🎉 Another contribution from our awesome community member, HazemKhaled! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good, PR approved!

@hansemannn hansemannn merged commit d0a48c1 into tidev:master Jun 28, 2018
@hansemannn hansemannn removed this from the 7.4.0 milestone Aug 24, 2018
@hansemannn hansemannn added this to the 7.5.0 milestone Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants