New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24317] Android: Focus area for view pinch event #8757
Conversation
Can one of the admins verify this patch? |
apidoc/Titanium/UI/View.yml
Outdated
summary: | | ||
true if a scale gesture is in progress. | ||
Note: This property is only available for Android | ||
type: Number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all docs here, please add:
since: "6.2.0"
platforms: [android]
And remove the Note: This property is only available for Android
after that. Also make sure to break the lines when they're getting too long. Check the existing docs for reference.
iOS Parity available for (some of) the properties? |
Another thing I notices aside from this PR: The docs say that the "pinch" gesture is only available on iOS (since 1.8.0), but obviously it's available on Android as well. Do you know since when? I' git-blame-check it otherwiese |
As usual you faster, thanks for updating docs, don't have a plan to implement it with iOS. |
Hey @HazemKhaled, I'd like to integrate this today! Can you please do me a huge favor and sign the CLA again? We moved to a unified Axway CLA server recently that requires to re-sign once. Thank you! |
From where i can sign the new one? |
It is here, linked via the "Details" button right to the CLA status. May be hard to find indeed :-). |
Done (Y) |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR looks good, PR approved!
JIRA: https://jira.appcelerator.org/browse/TIMOB-24317
EDIT by Hans:
no tests
, because only testable by pinching with the actual finger, so a manual test is required.