[TIMOB-11278] iOS: Add Ti.UI.WebView.ignoreSslError (Parity) #8786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
commented
Jan 25, 2017
| id reloadDataProperties; | ||
| SEL reloadMethod; | ||
| SEL reloadMethod; |
There was a problem hiding this comment.
Notes 1/2: I moved all properties to the updated indentation, so we have it easier in the future to add more properties without indentation issues.
| [self loadURLRequest:newRequest]; | ||
| [newRequest release]; | ||
|
|
||
| return NO; | ||
| } |
There was a problem hiding this comment.
Note 2/2: I moved the requestHeaders logic into the newHeaders scope, so it doesn't affect requests without custom request headers. This fixes a possible glitch in TIMOB-24329
vijaysingh-axway
approved these changes
Jan 26, 2017
longton95
requested review from
longton95
and removed request for
ewieberappc
longton95
approved these changes
Jan 31, 2017
There was a problem hiding this comment.
FR passed.
verified that iOS devices are now able to ignore invalid SSL certificate.
Ran the test-case from the ticket and a modified version.
ENV
SDK Version : Local 6.1.0 & 6.0.2
Mac OS Version : 10.12.2
Xcode Version : Xcode 8.2 Build version 8C38
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0
Device: iPhone 6 (10.2.1) iPhone 5 (9.3.5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-11278