Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_0_X][TIMOB-24253] Android: onBackPressed() validate topWindow before hasProperty() #8797

Merged
merged 1 commit into from Jan 26, 2017
Merged

[6_0_X][TIMOB-24253] Android: onBackPressed() validate topWindow before hasProperty() #8797

merged 1 commit into from Jan 26, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jan 26, 2017 •
edited

@lokeshchdhry
Copy link
Contributor

FR passed.
Checked with the code above. Fix looks good. The app does not crash after we return back to the app from an androidback event.
Also, checked the original issue & works well.

Appc Studio : 4.8.1.201612050850
Mac OS Version : 10.12.2
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.9-1","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0

@lokeshchdhry lokeshchdhry merged commit e6cabfb into tidev:6_0_X Jan 26, 2017
@hansemannn hansemannn added this to the 6.0.2 milestone Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokeshchdhry lokeshchdhry Awaiting requested review from lokeshchdhry

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @lokeshchdhry @hansemannn