Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_0_X][TIMOB-24304] Android: Use application context for permissions #8800

Merged
merged 1 commit into from Feb 16, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jan 28, 2017

  • Use application context instead of activity context for permissions

JIRA Ticket

@garymathews garymathews changed the title [6_0_X][TIMOB-24304] Android: Use application context for location permissions [6_0_X][TIMOB-24304] Android: Use application context for permissions Jan 30, 2017
@maggieaxway
Copy link
Contributor

CR pass

Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM Version: 2.15.9
Node Version: 4.5.0
Mac OS: 10.12.1
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Appcelerator Studio, build: 4.8.1.201612050850
Android Device 6.0.1

FR Passed. I followed the steps in the instruction detailed in the ticket. After launching the app, I clicked on "Start", and then put the app in the background. Then I brought the app in the foreground and clicked "Start" again. I then put the app in the background. No errors were see during the test.

@mukherjee2 mukherjee2 merged commit cffce3b into tidev:6_0_X Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants