[TIMOB-23391] : iOS View is not getting horizontally wrapped properly #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CR & FT works, but we need to discuss a few more items:
@ewieberappc We need to test this PR very detailed to avoid layout regressions. It looks goo to me, but you guys might have more test-cases to check with. |
hansemannn
approved these changes
Jan 31, 2017
ewieberappc
approved these changes
Feb 15, 2017
There was a problem hiding this comment.
FR Passed. Tested using:
MacOS 10.12 (16A323)
Studio 4.8.1.201701192045
Ti SDK 6.1.0
Appc NPM 4.2.8
Appc CLI 6.1.0
Alloy 1.9.6
Xcode 8.3 (8W120l)
Tested the provided sample code, ran our layout test suites, KitchenSink tests around layout, and any local projects I had that modified layouts in any way. No errors encountered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-23391