Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24358] iOS: Fix Ti.Media audio-players on device #8806

Merged
merged 1 commit into from Feb 9, 2017
Merged

[TIMOB-24358] iOS: Fix Ti.Media audio-players on device #8806

merged 1 commit into from Feb 9, 2017

Conversation

hansemannn
Copy link
Collaborator

vijaysingh-axway
vijaysingh-axway approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FT and CR passed.

@mukherjee2 mukherjee2 requested review from mukherjee2 and removed request for ewieberappc February 8, 2017 18:58
@htbryant94 htbryant94 self-assigned this Feb 9, 2017
@htbryant94 htbryant94 self-requested a review February 9, 2017 14:03
htbryant94
htbryant94 approved these changes Feb 9, 2017
View reviewed changes
Copy link

@htbryant94 htbryant94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Approved, Ti.Media.openMusicLibrary() no longer causes an app to fail on device builds. Tested with iOS9.3 and iOS10.2.

@htbryant94 htbryant94 merged commit 106a117 into tidev:master Feb 9, 2017
mukherjee2
mukherjee2 reviewed Feb 9, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR. FR was done with this environment:
NPM Version: 2.15.9
Node Version: 4.5.0
Mac OS: 10.12.1
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Appcelerator Studio, build: 4.8.1.201612050850
iOS Device: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 left review comments

@htbryant94 htbryant94 htbryant94 approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@htbryant94 htbryant94

Labels
in-qe-testing 🕵
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @mukherjee2 @htbryant94 @vijaysingh-axway