Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24344] Android: Fix getDensity() for tvdpi #8808

Merged
merged 1 commit into from Feb 7, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jan 31, 2017

  • Fix getDensity() of 213dpto tvdpi
TEST CASE
Ti.API.info('density: ' + Ti.Platform.displayCaps.getDensity());

JIRA Ticket

@garymathews garymathews added this to the 6.1.0 milestone Jan 31, 2017
@hansemannn hansemannn requested review from hansemannn and removed request for hansemannn February 6, 2017 17:48
@hansemannn
Copy link
Collaborator

@garymathews Can you add a tiny test-case / environment for this, so QE can pick it up more quicky?

@maggieaxway
Copy link
Contributor

CR passed

@maggieaxway maggieaxway merged commit 5fbf08f into tidev:master Feb 7, 2017
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 7, 2017

@maggieaxway , I see you have merged the PR, with the new process the QE team merges the PR when they are done with the FR, you have to just add the in-qe-testing label so that we know we can pick the PR for FR.

@hansemannn
Copy link
Collaborator

@lokeshchdhry Agree. Should I revert the merge or can you use the merged one for this one?

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Feb 7, 2017

@hansemannn, No need to revert, the merged one should be fine. I will just comment my FR results here as well.

@lokeshchdhry
Copy link
Contributor

FR passed.

Checked by creating an emulator with tvdpi & getting the Ti.Platform.displayCaps.getDensity() returned TVDPI which is correct.

Appc Studio : 4.8.1.201612050850
SDK Version : Locally built for this PR.
Mac OS Version : 10.12.2
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.9-1","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0

@maggieaxway
Copy link
Contributor

@lokeshchdhry @hansemannn Thanks for reminding. I will take note next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants