Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_0_X][TIMOB-24308] Android: Use Math.floor() when converting percentage values #8836

Merged
merged 1 commit into from Feb 14, 2017

Conversation

garymathews
Copy link
Contributor

Copy link
Contributor

@antw12 antw12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me after taking a look and doing a CR on it, its ready for an FR

Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM Version: 2.15.9
Node Version: 4.5.0
Mac OS: 10.12.1
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Passed FR with this environment:
NPM Version: 2.15.9
Node Version: 4.5.0
Mac OS: 10.12.1
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Appcelerator Studio, build: 4.8.1.201612050850
Android Device: 7.1, 7.1.1, 6.0.1

Tested with Google Pixel, and Pixel XL. Four color bars were seen in either Portrait or Landscape mode, as expected. Gray bar was not seen, as expected. For future regression testing, this needs to the tested with Pixel at the minimum.

@mukherjee2 mukherjee2 merged commit cda184e into tidev:6_0_X Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants