Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24407] Android: Fix TiUIDatePicker for API 21 and above #8839

Merged
merged 1 commit into from Feb 21, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Feb 16, 2017

  • Fix TiUIDatePicker version check
TEST CASE
var win = Titanium.UI.createWindow({
        title: 'TIMOB-24407',
        backgroundColor: 'gray'
    }),
    picker = Ti.UI.createPicker({
        calendarViewShown: false,
        type: Ti.UI.PICKER_TYPE_DATE
    });

win.add(picker);
win.open();

JIRA Ticket

Copy link
Contributor

@antw12 antw12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Code Review and FT, PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

If calendarViewShown: false then just the Ti.UI.PICKER_TYPE_DATE is shown.
Checked it on android API 16 to 25.

Appc Studio : 4.8.1.201612050850
SDK Version : Locally built 6.1.0 SDK
Mac OS Version : 10.12.2
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.9-2","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Android Emulator : API 16 - 25

@lokeshchdhry lokeshchdhry merged commit 46e7ebd into tidev:master Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants