Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23556] Android: Updated the package json vendor dependency for android build tools #8840

Merged
merged 2 commits into from Feb 20, 2017

Conversation

antw12
Copy link
Contributor

@antw12 antw12 commented Feb 17, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-23556

Optional Description:
Updated the dependency for one of the vendors in the package json, due to a warning about support with android build tools.

Test Case

  • Create new classic application
  • Run application in default state and check the logs
  • Logs should not have the following warning:

[WARN] : Android Build Tools 24 are too new and may or may not work with Titanium.
[WARN] : If you encounter problems, select a supported version with:
[WARN] : ti config android.buildTools.selectedVersion ##.##.##

@garymathews
Copy link
Contributor

CR: PASS
FT: PASS

👍

@garymathews garymathews added this to the 6.1.0 milestone Feb 20, 2017
@longton95 longton95 self-requested a review February 20, 2017 16:13
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

The current build tools no longer throw a warning message.

ENV

SDK Version : Local 6.1.0
Mac OS Version : 10.12.3
Android SDK Build-tools: 25.0.2
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.1)
Emulator: (6.0), (4.4.2)

@longton95 longton95 merged commit 43dccff into tidev:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants