Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24399] Android: Fix Ti.UI.WebView.html property setter #8854

Merged
merged 1 commit into from Mar 9, 2017

Conversation

garymathews
Copy link
Contributor

  • Fix Titanium.UI.WebView.html property setter
  • Remove unnecessary and undocumented optional argument from Titanium.UI.WebView.setHtml
TEST CASE
var win = Ti.UI.createWindow(),
    webView = Ti.UI.createWebView();
 
webView.html = '<h1>Hello</h1>';

win.add(webView);
win.open();

JIRA Ticket

@maggieaxway
Copy link
Contributor

CR FT pass

@mukherjee2 mukherjee2 self-requested a review March 9, 2017 17:26
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed with this environment:
NPM Version: 2.15.9
Node Version: 4.5.0
Mac OS: 10.12.3
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Appcelerator Studio, build: 4.8.1.201612050850
Android Device 6.0.1 and 7.1

I first verified the bug on SDK 6.0.2 The fix is validated with this PR. I am able to see "hello" when installing the app on Android 6 and 7 devices.

@mukherjee2 mukherjee2 merged commit 759e856 into tidev:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants