Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24448] iOS: Decouple Ti.Media music-API macros #8857

Merged
merged 2 commits into from Mar 8, 2017

Conversation

hansemannn
Copy link
Collaborator

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think following mentioned macros are of now use. Please remove.

  1. Remove macros from line of MediaModule.h-
    #if defined(USE_TI_MEDIASYSTEMMUSICPLAYER) || defined (USE_TI_MEDIAAPPMUSICPLAYER)
    #import "TiMediaMusicPlayer.h"
    #endif

2.Remove macro USE_TI_MEDIAMUSICPLAYER, line no 212, 272
3.Remove USE_TI_MEDIASYSTEMMUSICPLAYER and USE_TI_MEDIAAPPMUSICPLAYER from
#if defined(USE_TI_MEDIASYSTEMMUSICPLAYER) || defined (USE_TI_MEDIAAPPMUSICPLAYER)
RELEASE_TO_NIL(systemMusicPlayer);
RELEASE_TO_NIL(appMusicPlayer);
#endif

@hansemannn
Copy link
Collaborator Author

Updated, thx!

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FT and CR passed.

Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, using:
MacOS 10.12 (16A323)
Studio 4.8.1.201612050850
Ti SDK 6.1.0
Appc NPM 4.2.8
Appc CLI 6.1.0
Alloy 1.9.5
Xcode 8.2.1 (8C1002)

Tested using the provided code in TIMOB-24448 and TIMOB-24449 as well as running the QE Media Test Suite and submitting an app to the store that uses many ti.media methods/properties. All projects compiled and no errors were encountered

@ewieberappc ewieberappc merged commit f9c4153 into tidev:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants