Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24451] Android: Fix Ti.UI.ListView.getSectionCount() #8862

Merged
merged 1 commit into from Mar 14, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Mar 6, 2017

  • Fix handleSectionCount() to return pre-loaded section count when a view has not been assigned
TEST CASE

JIRA Ticket

@garymathews garymathews added this to the 6.1.0 milestone Mar 6, 2017
@garymathews garymathews requested a review from antw12 March 8, 2017 11:53
Copy link
Contributor

@antw12 antw12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & FT PASS 👍

@ssjsamir ssjsamir self-assigned this Mar 14, 2017
@ssjsamir
Copy link
Contributor

ssjsamir commented Mar 14, 2017

FR Passed Using the project provided above. Was able to see the return of section count which does not vary because of this i can see the section array.

Steps taken to test

  • Downloaded the project shown in the description
  • Imported the project into Appcelerator studio
  • Ran the program (Alloy)
  • Was able to see the return of section count which does not vary

Output shown from console (One line in the console)
[INFO] : {"caseInsensitiveSearch":true,"defaultItemTemplate":"detailsTemplate","sections":[{"headerTitle":null,"footerTitle":null,"items":[],"footerView":null,"headerView":null,"keepScreenOn":false,"children":[],"size":{"height":0,"width":0,"y":0,"x":0},"rect":{"height":0,"width":0,"y":0,"x":0},"apiName":"Ti.UI.ListSection","bubbleParent":true,"id":"__alloyId20"}],"canScroll":true,"sectionCount":1,"hiddenBehavior":4,"enabled":true,"visible":true,"touchEnabled":true,"backgroundRepeat":false,"height":"fill","keepScreenOn":false,"children":[],"size":{"height":523,"width":411,"y":0,"x":0},"rect":{"height":523,"width":411,"y":80,"x":0},"apiName":"Ti.UI.ListView","bubbleParent":true,"templates":{"detailsTemplate":{"properties":{"name":"detailsTemplate"},"childTemplates":[{"type":"Ti.UI.View","properties":{"height":40},"tiProxy":{"hiddenBehavior":4,"enabled":true,"visible":true,"touchEnabled":true,"backgroundRepeat":false,"height":40,"keepScreenOn":false,"children":[],"size":{"height":0,"width":0,"y":0,"x":0},"rect":{"height":0,"width":0,"y":0,"x":0},"apiName":"Ti.UI.View","bubbleParent":true}}],"tiProxy":{"hiddenBehavior":4,"enabled":true,"visible":true,"touchEnabled":true,"backgroundRepeat":false,"keepScreenOn":false,"children":[],"size":{"height":0,"width":0,"y":0,"x":0},"rect":{"height":0,"width":0,"y":0,"x":0},"apiName":"Ti.UI.ListItem","bubbleParent":true}}},"id":"detailsList"}

Environment
Appcelerator Command-Line Interface, version 6.1.0
Android Nexus 6p
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants