Fix [TIMOB-24470] Android: Fails to build modules that contain additi…

[sgtcoolguy]

…onal java files inside plugins folder or test folders not intended to be in distributed module

JIRA: https://jira.appcelerator.org/browse/TIMOB-24470

This blocks usage of "appc ti build" to build our hyperloop.next module/plugin (for android)

[garymathews]

CR: PASS
FT: PASS

👍

[sgtcoolguy]

@longton95 So the change here is that when we run appc ti build --build-only on an android native module, we used to scan the entire project for .java as a last compilation pass. Now we only scan src/**/.java and build/gen/**/*.java to build up that listing (which gets written as java-sources.txt file)

Building hyperloop.next/android was able to reproduce this issue because I have java files in a test-src folder, and in the plugins folder. You could generate a native android module project and just add some folder like "tests" and place a java source file there and ensure it no longer gets included in the list of files to compile.

[longton95]

FR passed.

Tested with a blank module and added test-src, plugins and stuff containing blank .java and tests from from the hyperloop.next files, .java file are not added to distributed module if they are not in src/**/.java and build/gen/**/*.java.

Thanks @sgtcoolguy

sources.txt

"/Users/Josh/apps/TIMOB-24470/android/src/com/appc/TIMOB24470/ExampleProxy.java"
"/Users/Josh/apps/TIMOB-24470/android/src/com/appc/TIMOB24470/TIMOB24470Module.java"
"/Users/Josh/apps/TIMOB-24470/android/build/generated/java/com/appc/TIMOB24470/TIMOB24470Bootstrap.java"

Test module tree

├── Resources
│   └── README.md
├── build.properties
├── build.xml
├── java-sources.txt
├── lib
│   └── README
├── libs
│   ├── armeabi-v7a
│   │   └── libcom.appc.TIMOB24470.so
│   └── x86
│       └── libcom.appc.TIMOB24470.so
├── manifest
├── platform
│   └── README.md
├── plugins
│   ├── 4.java
│   ├── 5.java
│   └── 6.java
├── src
│   └── com
│       └── appc
│           └── TIMOB24470
│               ├── ExampleProxy.java
│               └── TIMOB24470Module.java
├── stuff
│   └── stuff.java
├── test-src
│   ├── 1.java
│   ├── 2.java
│   └── 3.java
└── timodule.xml

ENV

SDK Version : Local 6.1.0, 6.0.3
Mac OS Version : 10.12.3
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0