Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(6_0_X)[TIMOB-24470] Android: Fails to build modules that contain additi… #8876

Merged
merged 1 commit into from Mar 10, 2017

Conversation

sgtcoolguy
Copy link
Contributor

…onal java files inside plugins folder or test folders not intended to be in distributed module

JIRA: https://jira.appcelerator.org/browse/TIMOB-24470

…onal java files inside plugins folder or test folders not intended to be in distributed module
@sgtcoolguy sgtcoolguy added this to the 6.0.2 milestone Mar 9, 2017
@hansemannn hansemannn removed this from the 6.0.2 milestone Mar 10, 2017
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS
FT: PASS

@longton95
Copy link
Contributor

longton95 commented Mar 10, 2017

FR passed.

Tested with a blank module and added test-src, plugins and stuff containing blank .java and tests from from the hyperloop.next files, .java file are not added to distributed module if they are not in src/**/.java and build/gen/**/*.java.

sources.txt

"/Users/Josh/apps/TIMOB-24470/android/src/com/appc/TIMOB24470/ExampleProxy.java"
"/Users/Josh/apps/TIMOB-24470/android/src/com/appc/TIMOB24470/TIMOB24470Module.java"
"/Users/Josh/apps/TIMOB-24470/android/build/generated/java/com/appc/TIMOB24470/TIMOB24470Bootstrap.java"

Test module tree

├── Resources
│   └── README.md
├── build.properties
├── build.xml
├── java-sources.txt
├── lib
│   └── README
├── libs
│   ├── armeabi-v7a
│   │   └── libcom.appc.TIMOB24470.so
│   └── x86
│       └── libcom.appc.TIMOB24470.so
├── manifest
├── platform
│   └── README.md
├── plugins
│   ├── 4.java
│   ├── 5.java
│   └── 6.java
├── src
│   └── com
│       └── appc
│           └── TIMOB24470
│               ├── ExampleProxy.java
│               └── TIMOB24470Module.java
├── stuff
│   └── stuff.java
├── test-src
│   ├── 1.java
│   ├── 2.java
│   └── 3.java
└── timodule.xml

ENV

SDK Version : Local 6.1.0, 6.0.3
Mac OS Version : 10.12.3
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants