Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24474] Fix proxy values in animation #8880

Merged
merged 1 commit into from Mar 13, 2017
Merged

[TIMOB-24474] Fix proxy values in animation #8880

merged 1 commit into from Mar 13, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.1.0 milestone Mar 12, 2017
vijaysingh-axway
vijaysingh-axway approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FT and CR passed.

@ssjsamir ssjsamir self-assigned this Mar 13, 2017
@ssjsamir
Copy link
Contributor

FR - Passed: With the sample code provided by @hansemannn in the Jira ticket https://jira.appcelerator.org/browse/TIMOB-24474 was able to see the proxy values change depending on the animation.

Steps I took to test:

  • Copied the code provided in the description
  • Created a classic Titanium project
  • Ran the program in Appcelerator Studio
  • Saw that an animation took place
  • Saw the proxy values change when clicking on the view animate button (unlike in 6.0.2.GA where the value would not change)

Environement
Appcelerator Command-Line Interface, version 6.1.0
Iphone 6S OS: 10.0
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir merged commit ef48708 into tidev:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

@ewieberappc ewieberappc Awaiting requested review from ewieberappc

Assignees

@ssjsamir ssjsamir

Labels
in-qe-testing 🕵
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @ssjsamir @vijaysingh-axway