Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24459] Android: Allow automatic permissions to be overriden #8881

Merged
merged 1 commit into from Mar 22, 2017

Conversation

garymathews
Copy link
Contributor

  • Allow override-permissions in tiapp.xml to prevent automatic permissions from being defined in AndroidManifest.xml
<ti:app xmlns:ti="http://ti.appcelerator.org">
    ...
    <override-permissions>true</override-permissions>
    ...
</ti:app>

JIRA Ticket

@maggieaxway
Copy link
Contributor

CR FT pass

Need manually add Internet permission in tiapp.xml to make sure the app works

    <android xmlns:android="http://schemas.android.com/apk/res/android">
    	<manifest android:versionCode="1" android:versionName="1.0">
		<application>
		</application>
		<uses-permission android:name="android.permission.INTERNET"/>
	</manifest>
    <abi>armeabi-v7a</abi>
    </android>

@longton95 longton95 self-requested a review March 22, 2017 16:24
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested by adding <override-permissions>true</override-permissions> to the tiapp.

The only permissions added added are

<uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.READ_LOGS"/>
<uses-permission android:name="android.permission.GET_TASKS"/>

Any other permissions have to be manually added.

ENV

SDK Version : Local 6.1.0
Mac OS Version : 10.12.3
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.2)
Emulator: (6.0), (4.4.2)

@longton95 longton95 merged commit 59b9436 into tidev:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants