Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [TIMOB-24480] Android: appc run based module builds fail due to double-namespaced classes in KrollGeneratedBindings.gperf #8882

Merged
merged 1 commit into from Mar 15, 2017

Conversation

sgtcoolguy
Copy link
Contributor

  • When full class name already includes the namespace in it, don't pre-pend the namespace
  • Also fix handling when an Android module doesn't contain a "libs" directory.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24480

…ouble-namespaced classes in KrollGeneratedBindings.gperf

- When full class anem already includes the namespace in it, don't pre-pend the namespace
- Also fix handling when an Android module doesn't contain a "libs" directory.
@sgtcoolguy
Copy link
Contributor Author

This was something I ran into specifically when attempting to build the ti.facebook module for Android using appc ti build --build-only

When compiling it would give errors like:

...generated/KrollGeneratedBindings.gperf:20:51: error: 'facebook::facebook' has not been declared

And, when I fixed that issue, I still ran into errors around trying to read a non-existent "libs" folder. So this PR also fixes our handling when there are no -pre-packaged/pre-compiled native *.so files under a libs folder (we try and check that the architectures match those defined in the module manifest if any do exist, but only if the folder exists now).

@hansemannn
Copy link
Collaborator

@sgtcoolguy I saw the ones with the non-existing "libs" one as Generating an empty directory fixed it for me, so maybe we can do something similar to what you did in #8876 ?

@sgtcoolguy
Copy link
Contributor Author

@hansemannn I'm not sure what you mean here. This PR does fix the "libs" folder issue as well by guarding our reads of the directory with existence checks.

@hansemannn
Copy link
Collaborator

I've only read the first part (in compileAllFinal) before the comment. All clear now.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS
FT: PASS can build ti.facebook without any issues! 👍

@lokeshchdhry
Copy link
Contributor

FR Passed.

Facebook module built without any issues with appc run -p android --build-only.

Appc Studio : 4.8.1.201612050850
SDK Version : Locally built 6.1.0
Mac OS Version : 10.12.3
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.8","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0

@lokeshchdhry lokeshchdhry merged commit dee5b81 into tidev:master Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants