Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(6_0_X) [TIMOB-24479] Android: fix TiUILabel maxLines not working #8885

Merged
merged 1 commit into from Mar 15, 2017

Conversation

frankieandone
Copy link
Contributor

Test Case:
Expect the long string to be in one line meaning no word wraps.

var win = Ti.UI.createWindow({
	theme: "Theme.AppCompat.Fullscreen",
	backgroundColor: '#fff'
});
var longString = "Welcome to the Appcelerator Platform! The Appcelerator Platform extends Appcelerator's Titanium platform to help you manage the entire lifecycle of the application with debugging, testing, deployment, crash monitoring and analytic data collection.";
var bigLabel = Ti.UI.createLabel({
	text: longString,
	color: '#4d4d4d',
	width: "90%",
	top: 0,
	maxLines: 1
});
win.add(bigLabel);
win.open();

JIRA: https://jira.appcelerator.org/browse/TIMOB-24479

@chmiiller
Copy link
Contributor

thanks @fmerzadyan !

Copy link
Contributor

@antw12 antw12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & FT PASS 👍

@ssjsamir ssjsamir changed the title (6_0_X) timob-24479 Android: fix TiUILabel maxLines not working (6_0_X) [TIMOB-24479] Android: fix TiUILabel maxLines not working Mar 14, 2017
@ssjsamir
Copy link
Contributor

FR Passed was able to set a long string to 1 line.

Steps taken to test

  • Copied the test case in the description
  • Pasted the code into a titanium project in appcelerator studio
  • Ran the program on device
  • Saw that string was set to one line as part of the string was missing

Environment
Appcelerator Command-Line Interface, version 6.1.0
Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir merged commit 751ec2b into tidev:6_0_X Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants