Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_0_X][TIMOB-24531] Android: Fix exitOnClose behaviour #8907

Merged
merged 1 commit into from Mar 24, 2017
Merged

[6_0_X][TIMOB-24531] Android: Fix exitOnClose behaviour #8907

merged 1 commit into from Mar 24, 2017

Conversation

garymathews
Copy link
Contributor

@m1ga
Copy link
Contributor

m1ga commented Mar 24, 2017

Thank you for the fix!

@lokeshchdhry
Copy link
Contributor

FR Passed.

Window is closed only when exitOnClose is set to true & not otherwise. Which was not the case before this fix.
Checked using the sample code.
Also checked by opening a number of windows with exitOnClose property true & false & it works as expected.

Appc Studio : 4.8.1.201612050850
SDK Version : 6.0.4 locally built
Mac OS Version : 10.12.3
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.8","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0
Devices: Nexus 6 android 6.0.1, Pixel android 7.1
Emulator: Android 4.1.2

@lokeshchdhry lokeshchdhry merged commit d69edc1 into tidev:6_0_X Mar 24, 2017
@hansemannn hansemannn added this to the 6.0.4 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokeshchdhry lokeshchdhry Awaiting requested review from lokeshchdhry

@antw12 antw12 Awaiting requested review from antw12

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @m1ga @lokeshchdhry @hansemannn