[6_0_X][TIMOB-24497][TIMOB-24316][TIMOB-24527] Backport #8910

garymathews · 2017-03-27T15:59:32Z

Cherry-pick of [TIMOB-24497] Android: Resuming app from intent does not provide EXTRA data #8894 [TIMOB-24316] Android: Fix resuming activities when using intent-filters #8897 [TIMOB-24527] Android: Intents using FLAG_ACTIVITY_NEW_DOCUMENT can cause issues with KrollRuntime #8908

maggieaxway

CR FT PASS

Test case here: #8908

bert-w · 2017-04-05T09:51:41Z

having issues with this. android:launchMode="standard" in my manifest.

As soon as I install the app from scratch, it seems to open two instances/activities (i see my splash screen pop in and pop out). On the second launch, it hangs on the splash screen. I've tried android:launchMode="singleTask" as well.

EDIT: after exitting the app completely due to the above freeze, I am able to start it up as expected.

Also, launching a custom URL scheme intent to the app which is in background will not work (hangs on splash screen, and seems to open a new instance while it was actually in background). Completely closing the app and then clicking a custom URL scheme DOES seem to work correctly

garymathews · 2017-04-05T20:10:08Z

@Bertuzb I have updated this PR, please note that you cannot use android:launchMode with Titanium.

If you want android:launchMode="singleTask" behaviour, define:

<property name="intent-filter-new-task" type="bool">true</property>

in your tiapp.xml

bert-w · 2017-04-06T08:14:04Z

Ok the custom URL scheme seems to work now, regardless of background status or if app was closed (probably the intent-filter-new-task did the trick?).

However I see just one issue, which is a double splash screen (it seems to open two instances/activities) as soon as I install my app using appc ti build. It will not pass the splash screen.
After quiting the app, I can start it up as expected (and showing a single splash screen), and it all seems to work.

Note: I have not tested 87a6fab since I have no means to compile this SDK (im using the build which was compiled 2d ago, see comment https://jira.appcelerator.org/browse/TIMOB-15253)

jonesdhtx · 2017-04-06T11:31:17Z

@Bertuzb Bertuzb - It is failing for us with 2 different scenarios as described below, can you verify these happen for you as well?

(Note: I am using the same test build you referenced https://jira.appcelerator.org/browse/TIMOB-15253)

Previously, with the 6.0.3.GA release I was getting this:

From initial state with app not running - In the phone browser click on a link in a test html page
eg: <a href="testapp://order/11112222">Launch App</a>
Our app opens successfully and handles the link accordingly
Now leaving app open, return to the test html page, and click on the same link again
Our app ux hangs and shows only the splash screen (BROKE)

New Issue #1: Now with the updated build applied, I am getting this:

From initial state with app not running - In the phone browser click on a link in a test html page
eg: <a href="testapp://order/11112222">Launch App</a>
Our app opens successfully and handles the link accordingly
Now leaving app open, return to the test html page, and click on the same link again
Our app now opens successfully and handles the link accordingly (WORKS NOW!)
Repeat steps 3 and 4 any number of times and note it continues to work as expected
Now still leaving app open - return to the test html page and click on a different link this time:
eg: <a href="testapp://order/33334444">Launch App</a>
Our app ux now hangs and shows only the splash screen (BROKE)

New Issue #2: I noticed that it will fail in the same way if the app is open explicitly by the user before the initial link click:

From initial state with app not running - start the app from the app launcher
With the app launched and running normally, leave it open and then in the phone browser click on a link in a test html page
eg: <a href="testapp://order/11112222">Launch App</a>
Our app ux now hangs and shows only the splash screen (BROKE)

@garymathews - Could the 87a6fab change possibly address the issues I'm seeing?

Here is snippet of our tiapp.xml

<ti:app xmlns:ti="http://ti.appcelerator.org">
    ...
    <property name="run-on-main-thread" type="bool">true</property>
    <property name="intent-filter-new-task" type="bool">true</property>
    ...
    <android xmlns:android="http://schemas.android.com/apk/res/android">
        <manifest android:versionCode="16">
            <application android:hardwareAccelerated="true"
                android:largeHeap="true" android:theme="@style/Theme.Titanium">
                <activity android:name=".TestAppActivity" android:label="@string/app_name" android:theme="@style/Theme.Titanium" android:configChanges="keyboardHidden|orientation|screenSize" android:launchMode="singleTask">
                    <intent-filter>
                        <action android:name="android.intent.action.MAIN"/>
                        <category android:name="android.intent.category.LAUNCHER"/>
                    </intent-filter>
                    <intent-filter>
                        <action android:name="android.intent.action.VIEW"/>
                        <category android:name="android.intent.category.DEFAULT"/>
                        <category android:name="android.intent.category.BROWSABLE"/>
                        <data android:scheme="testapp" />
                    </intent-filter>
                </activity>
                <activity
                    android:configChanges="keyboardHidden|orientation"
                    android:hardwareAccelerated="true" android:name="io.card.payment.CardIOActivity"/>
                <activity android:name="io.card.payment.DataEntryActivity"/>
            </application>
            <uses-permission android:name="android.permission.CAMERA"/>
            <uses-permission android:name="android.permission.VIBRATE"/>
            <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
            <uses-feature android:name="android.hardware.location.gps"/>
            <uses-feature android:name="android.hardware.camera" android:required="false"/>
            <uses-feature
                android:name="android.hardware.camera.autofocus" android:required="false"/>
            <uses-feature android:name="android.hardware.camera.flash" android:required="false"/>
        </manifest>
    </android>
    ...
    <sdk-version>6.0.4.custom-preview</sdk-version>
    <plugins>
        ...
        <plugin version="1.0">ti.alloy</plugin>
        <plugin>hyperloop</plugin>
        ...
    </plugins>
    ...
</ti:app>

garymathews · 2017-04-06T11:39:27Z

@jonesdhtx Remove android:launchMode="singleTask" from your tiapp.xml and test again?

Here's a build with 87a6fab: 6.0.4_20170406.zip

jonesdhtx · 2017-04-06T11:53:30Z

@garymathews - Removing the android:launchMode setting had no effect, still getting both issues

bert-w · 2017-04-06T12:02:01Z

@jonesdhtx I cannot reproduce #1 or #2. Different URLs seem to work as intended for me. Note Im not using run-on-main-thread (I have not researched yet why one would want to use this setting, any idea?). However, my app does freeze when I build it from scratch (and its auto-launched) as previously mentioned.

Also I am now seeming to get multiple intent triggers while opening the same URL when simply resuming the app from background. Not to mention the fact that I'm confused by the naming of "intent-filter-new-task" because it seems to me everyone would want to use the same task.

Here's my tiapp.xml snippet:

...
<property name="intent-filter-new-task" type="bool">true</property>
...
<android xmlns:android="http://schemas.android.com/sapk/res/android">
        <manifest android:versionCode="18" android:versionName="2.1.5"
            package="com.myapp" xmlns:android="http://schemas.android.com/apk/res/android">
            <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="23"/>
            <uses-feature android:name="android.hardware.location" android:required="false"/>
            <application android:debuggable="false"
                android:hardwareAccelerated="true"
                android:icon="@drawable/appicon"
                android:label="MYAPP"
                android:largeHeap="true" android:theme="@style/Theme.Custom">
                <meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version"/>
                <activity android:label="@string/app_name"
                    android:launchMode="standard"
                    android:name=".MYAPP" android:theme="@style/Theme.Titanium">
                    <intent-filter>
                        <action android:name="android.intent.action.VIEW"/>
                        <category android:name="android.intent.category.DEFAULT"/>
                        <category android:name="android.intent.category.BROWSABLE"/>
                        <data android:scheme="myapp"/>
                    </intent-filter>
                    <intent-filter>
                        <action android:name="android.intent.action.MAIN"/>
                        <category android:name="android.intent.category.LAUNCHER"/>
                    </intent-filter>
                </activity>
            </application>
        </manifest>
    </android>

jonesdhtx · 2017-04-17T17:35:52Z

@garymathews - After playing around with it some more, I'm thinking the reason you weren't seeing the problem before might have to do with the use of back button vs home button (or task switcher)?

More info & link to sample project posted here: https://jira.appcelerator.org/browse/TIMOB-15253?focusedCommentId=417491&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-417491

lokeshchdhry · 2017-04-21T22:33:30Z

FR Passed.

TIMOB-24497:

Ran the test code & verified it does not show any issues & runs as expected.

TIMOB-24316:

Ran specified steps & checked if PR fixes customer issue.

TIMOB-24527:

Checked applications like Gmail which use intents using FLAG_ACTIVITY_NEW_DOCUMENT work properly & as expected,.

Studio Ver : 4.8.1.201612050850
SDK Ver : 6.0.4 local build
OS Ver : 10.12.3
Xcode Ver : Xcode 8.3.2
Appc NPM : 4.2.9
Appc CLI : 6.2.0
Ti CLI Ver : 5.0.12
Alloy Ver : 1.9.11
Node Ver : 6.10.1
Java Ver : 1.8.0_101
Devices : google Nexus 6P --- Android 7.1.1
google Nexus 6 --- Android 6.0.1

Gary Mathews added 3 commits March 27, 2017 16:51

[TIMOB-24497] Fix obtaining intent data when resuming activity

dddb6a3

[TIMOB-24316] Fix resuming intent-filter intents

b839448

[TIMOB-24527] Handle activities launched with FLAG_ACTIVITY_NEW_DOCUMENT

e33dbfc

garymathews added the android label Mar 27, 2017

garymathews requested a review from lokeshchdhry March 27, 2017 15:59

maggieaxway added the in-qe-testing 🕵 label Mar 29, 2017

maggieaxway self-requested a review March 29, 2017 07:42

maggieaxway approved these changes Mar 29, 2017

View reviewed changes

[TIMOB-24316] Update documentation

37ebd2c

hansemannn added this to the 6.0.4 milestone Mar 29, 2017

garymathews force-pushed the backport_24497_24316_24527 branch 2 times, most recently from 13138e3 to 87a6fab Compare April 5, 2017 21:54

Gary Mathews added 2 commits April 6, 2017 13:17

[TIMOB-24316] Fix category condition

d866711

[TIMOB-24316] Fix KrollRuntime bug

2d0cf52

garymathews force-pushed the backport_24497_24316_24527 branch 2 times, most recently from 8b5fdee to ddc37c0 Compare April 6, 2017 13:16

[TIMOB-24316] Ignore launchMode in tiapp.xml

b48ec5d

garymathews force-pushed the backport_24497_24316_24527 branch from ddc37c0 to b48ec5d Compare April 14, 2017 17:48

lokeshchdhry merged commit e12b1d8 into tidev:6_0_X Apr 21, 2017

This was referenced May 1, 2017

[TIMOB-24316] Android: Fix resuming activities when using intent-filters #8897

Merged

[TIMOB-24527] Android: Intents using FLAG_ACTIVITY_NEW_DOCUMENT can cause issues with KrollRuntime #8908

Merged

garymathews mentioned this pull request May 3, 2017

[6_1_X] Cherry-pick missing fixes from 6_0_X #9009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6_0_X][TIMOB-24497][TIMOB-24316][TIMOB-24527] Backport #8910

[6_0_X][TIMOB-24497][TIMOB-24316][TIMOB-24527] Backport #8910

garymathews commented Mar 27, 2017

maggieaxway left a comment •

edited

bert-w commented Apr 5, 2017 •

edited

garymathews commented Apr 5, 2017

bert-w commented Apr 6, 2017

jonesdhtx commented Apr 6, 2017

garymathews commented Apr 6, 2017 •

edited

jonesdhtx commented Apr 6, 2017

bert-w commented Apr 6, 2017

jonesdhtx commented Apr 17, 2017

lokeshchdhry commented Apr 21, 2017 •

edited

[6_0_X][TIMOB-24497][TIMOB-24316][TIMOB-24527] Backport #8910

[6_0_X][TIMOB-24497][TIMOB-24316][TIMOB-24527] Backport #8910

Conversation

garymathews commented Mar 27, 2017

maggieaxway left a comment • edited

Choose a reason for hiding this comment

bert-w commented Apr 5, 2017 • edited

garymathews commented Apr 5, 2017

bert-w commented Apr 6, 2017

jonesdhtx commented Apr 6, 2017

Previously, with the 6.0.3.GA release I was getting this:

New Issue #1: Now with the updated build applied, I am getting this:

New Issue #2: I noticed that it will fail in the same way if the app is open explicitly by the user before the initial link click:

Here is snippet of our tiapp.xml

garymathews commented Apr 6, 2017 • edited

jonesdhtx commented Apr 6, 2017

bert-w commented Apr 6, 2017

jonesdhtx commented Apr 17, 2017

lokeshchdhry commented Apr 21, 2017 • edited

maggieaxway left a comment •

edited

bert-w commented Apr 5, 2017 •

edited

garymathews commented Apr 6, 2017 •

edited

lokeshchdhry commented Apr 21, 2017 •

edited