[TIMOB-24496]:iOS Camera overlay does not fill the entire screen when orientation is changed on iPad, Titanium SDK 6.0.0 and later #8915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… orientation is changed on iPad, Titanium SDK 6.0.0 and later
|
CR passed, the change I made was unnecessary! |
hansemannn
approved these changes
Mar 29, 2017
ssjsamir
approved these changes
Mar 30, 2017
There was a problem hiding this comment.
FR Passed, was able to see the entire camera overlay when the screen orientation of an iPad was set to landscape.
Test Steps
- Built the SDK from this PR
- Copied the code in the description of the Jira ticket (https://jira.appcelerator.org/browse/TIMOB-24496)
- Pasted the code in to a titanium project
- Ran the program
- Saw the camera overlay when the application first launched (Portrait)
- Changed the orientation of the iPad to landscape and saw that the overlay was fully visible
I then re-ran the steps on an older SDK 6.0.2.GA and saw that the overlay was not visible in landscape mode thus verifying that changes were made.
Environment
Appcelerator Command-Line Interface, version 6.1.0
Apple iPad air 2 (iOS 9.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-24496