Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24364] iOS: Fix HTTP-leak on Kroll-Thread #8918

Merged
merged 2 commits into from Apr 12, 2017
Merged

[TIMOB-24364] iOS: Fix HTTP-leak on Kroll-Thread #8918

merged 2 commits into from Apr 12, 2017

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-24364

@hansemannn hansemannn added this to the 6.1.0 milestone Mar 29, 2017
This was referenced Mar 29, 2017
Merged
Merged
@htbryant94 htbryant94 self-requested a review April 6, 2017 15:05
htbryant94
htbryant94 approved these changes Apr 12, 2017
View reviewed changes
Copy link

@htbryant94 htbryant94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Monitored memory allocation of both test cases with instruments, and observed that memory is correctly deallocated after operations conclude.

@htbryant94 htbryant94 merged commit 4bdf69f into tidev:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htbryant94 htbryant94 htbryant94 approved these changes

@vijaysingh-axway vijaysingh-axway Awaiting requested review from vijaysingh-axway

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansemannn @htbryant94