Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18301] iOS: Fix linearVelocityForItem crash #8920

Merged
merged 2 commits into from May 24, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.2.0 milestone Mar 29, 2017
@hansemannn
Copy link
Collaborator Author

@vijaysingh-axway ping

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed

@htbryant94 htbryant94 self-requested a review May 24, 2017 14:40
Copy link

@htbryant94 htbryant94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Calling the linearVelocityForItem method for Titanium.UI.iOS.DynamicItemBehavior no longer causes a crash, and behaves as expected.

Tested On:
iPhone 7 10.3.2 Device & Simulator
Mac OS Sierra (10.12.2)
Appc NPM: 4.2.9-1
App CLI: 6.1.0
Xcode 8.2.1
Node v4.6.0

@hansemannn hansemannn merged commit 0255137 into tidev:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants