[TIMOB-23887]:Attributed string link on a TextArea doesn't fire link event #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Apr 10, 2017
iphone/Classes/TiUITextArea.m
Outdated
| @@ -5,7 +5,7 @@ | |||
| * Please see the LICENSE included with this distribution for details. | |||
| */ | |||
| #ifdef USE_TI_UITEXTAREA | |||
|
|
|||
| #import "TiUIAttributedStringProxy.h" | |||
There was a problem hiding this comment.
Everything related to other proxies should be wrapped:
#ifdef USE_TI_UIATTRIBUTEDSTRING
#import "TiUIAttributedStringProxy.h"
#endifSee the TiUITextWidget.m implementation for details.
There was a problem hiding this comment.
Done. Thanks.
iphone/Classes/TiUITextArea.m
Outdated
| -(void)checkLinkForTouch:(UITouch *)touch | ||
| { | ||
| // TIMOB-23887: This is similar to UILabel implementation, rather native link recognizer of UITextView, to support TIMOB-19165. | ||
| BOOL testLink = (textWidgetView != nil) &&([(TiViewProxy*)[self proxy] _hasListeners:@"link" checkParent:NO]); |
There was a problem hiding this comment.
Missing space in ) &&(.
iphone/Classes/TiUITextArea.m
Outdated
| } | ||
| } | ||
|
|
||
| - (NSUInteger)characterIndexAtPoint:(NSAttributedString*)theString atPoint:(CGPoint)point |
There was a problem hiding this comment.
NSAttributedString* NSAttributedString *
hansemannn
approved these changes
May 3, 2017
ewieberappc
approved these changes
May 9, 2017
There was a problem hiding this comment.
FR Passed, using:
MacOS 10.12 (16A323)
Studio 4.9.0.201704061825
Ti SDK 6.1.0.v20170503211832
Appc NPM 4.2.9
Appc CLI 6.2.0
Alloy 1.9.11
Xcode 8.3.2 (8E2002)
Attributed strings, inside non-editable text areas, with links now correctly fire the link event when clicked. Tested using the sample code and modified it to fully apply to the test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-23887