[TIMOB-23313] (6_0_X) Disabled Swift settings for main Titanium project #8946
Conversation
…ensure they are enabled in the extension targets.
|
LGTM. |
hansemannn
changed the title
| @@ -2947,14 +2947,14 @@ | |||
| isa = XCBuildConfiguration; | |||
| baseConfigurationReference = 241EAEC5118E2BA90081A5BE /* project.xcconfig */; | |||
| buildSettings = { | |||
| ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES; | |||
| ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = NO; | |||
| ALWAYS_SEARCH_USER_PATHS = NO; | |||
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | |||
| ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage; | |||
| CODE_SIGN_ENTITLEMENTS = Titanium.entitlements; | |||
There was a problem hiding this comment.
I notived that this is called "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; on 6.1.x and master.
There was a problem hiding this comment.
So? There was probably a reason to do it in master/6.1.x, but that has nothing to do with this PR.
There was a problem hiding this comment.
Just wondered and mentioned it, eaasy man! 🙂
There was a problem hiding this comment.
Hans, Can I take this a "CR Passed?" FR passed, so may I merge it?
There was a problem hiding this comment.
Yeah, we're ready to merge. I'll go ahead and merge all three then, thx!
| ALWAYS_SEARCH_USER_PATHS = NO; | ||
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage; | ||
| CODE_SIGN_ENTITLEMENTS = Titanium.entitlements; | ||
| COPY_PHASE_STRIP = YES; | ||
| EMBEDDED_CONTENT_CONTAINS_SWIFT = YES; | ||
| DEVELOPMENT_TEAM = ""; |
There was a problem hiding this comment.
This is also not included in 6.1.x and master.
There was a problem hiding this comment.
DEVELOPMENT_TEAM was removed in master when master was 6.1.0.
There was a problem hiding this comment.
FR passed with this environment:
NPM Version: 3.10.10
Node Version: 6.10.1
Mac OS: 10.12.3
Appc CLI: 6.1.0
Appc CLI NPM: 4.2.8
Appcelerator Studio, build: 4.8.1.201612050850
Xcode 8.2.1
I followed the test steps outlined in the JIRA ticket and found that only the Watch targets had Swift enabled in the Xcode project.
[TIMOB-23313] Disabled Swift settings for main Titanium project, but ensure they are enabled in the extension targets.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23313