Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24567] iOS: Use Swift 3.1 for watchOS templates, update pairing table #8952

Merged
merged 6 commits into from Apr 10, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Apr 8, 2017

'3.x': true // watchOS 3.x
'>=8.3': { // Xcode 8.3
'10.x': { // - iOS 10.x
'>=3.x': true // - watchOS 3.x
}
Copy link
Collaborator Author

@hansemannn hansemannn Apr 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cb1kenobi As soon as we conclude on the table, I'd do an ioslib PR. Here are the changes:

  • Removed all Xcode versions < 8.2, because they are unsupported by the SDK anyway
  • Added handling for Xcode 8.3+, which requires the build target iOS 10.x and watchOS 3.x (iOS 10.x does not work with watchOS 2.x)

@cb1kenobi
Copy link
Contributor

This is awesome! Thanks for working on this.

Don't bother updating the ioslib files in titanium_mobile for other than testing. You are correct, we need to do them ioslib, publish a release, and update ioslib in titanium_mobile.

@@ -315,9 +303,9 @@ exports.detect = function detect(options, callback) {
}
};

Object.keys(simulatorDevicePairCompatiblity).some(function (xcodeRange) {
Object.keys(simulatorDevicePairCompatibility).some(function (xcodeRange) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@cb1kenobi
Copy link
Contributor

We need to stop modifying the "watchos2-swift" project template and create a "watchos3-swift".

@hansemannn
Copy link
Collaborator Author

Updated the template. Is it possible that we don't even use the watchos2-objc template anymore? The only reference I can find is 684a91e#diff-d69717379468fe83d78fc685c3797eefR68.

@cb1kenobi
Copy link
Contributor

Yeah, I think that's the only place you need to specify the template name.

@hansemannn
Copy link
Collaborator Author

Then w should drop the watchos2-objc template completely. When we create a new watchOS extension, it will use the Swift template anyway.

@hansemannn hansemannn added this to the 6.2.0 milestone Apr 10, 2017
@cb1kenobi
Copy link
Contributor

Works like a champ! APPROVED

@cb1kenobi cb1kenobi merged commit cd8393e into tidev:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants