Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17792] Android: Fix context passed to timePicker dialog builder. #8957

Merged
merged 2 commits into from Jun 13, 2017

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Apr 12, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-17792

Test
Described in the JIRA ticket

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jquick-axway
Copy link
Contributor

@lokeshchdhry, I recommend that you run your Android intent test with the DateTimePicker dialog to see if it's actually grabbing the current activity when multiple tasks exist.

@ssjsamir ssjsamir requested review from ssjsamir and removed request for lokeshchdhry June 13, 2017 22:10
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Was able to sett the timePicker dialog box when clicking on the "Show Time Picker Dialog" button from the following test case:

var win = Ti.UI.createWindow({
    exitOnClose: true
});
 
var picker = Ti.UI.createPicker({
    type: Ti.UI.PICKER_TYPE_TIME
});
 
var btn = Ti.UI.createButton({
    title : 'Show time picker dialog'
});
 
win.add( btn );
win.open( );
 
btn.addEventListener( 'singletap', function( ) {
    picker.showTimePickerDialog({
        callback: function( e ) {
            if ( e.cancel ) {
                Ti.API.info( 'User canceled dialog' );
            } else {
                Ti.API.info( 'User selected time: ' + e.value );
            }
        }
    });
});

Test steps

  • Downloaded the SDK Build form this PR
  • Created a new Titanium project
  • Copied the the test case from description
  • Ran the application
  • Pressed the Show TIme Picker Dialog button
  • Saw the time picker
  • Was able to set the time and press ok
  • Console showed select time
    [INFO] : User selected time: Tue Jun 13 2017 05:07:55 GMT-0700 (PDT)

Test Environment
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705251638

@ssjsamir ssjsamir merged commit ee5dcf8 into tidev:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants