[TIMOB-24574] iOS: Fix picker-selection #8958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apidoc/Titanium/UI/Picker.yml
Outdated
| @@ -353,10 +353,9 @@ properties: | |||
| If `true`, selection indicator is enabled. | |||
|
|
|||
| On iOS 7 and later, the picker indicator is always shown and you cannot control it. | |||
|
|
|||
| On iOS 6 and prior, if enabled, a blue bar is displayed to indicate the current selection. | |||
| Manually setting the property was deprecated in 6.1.0 and will be ignored by the SDK. | |||
There was a problem hiding this comment.
This is deprecated in iOS only. So iOS should be mentioned in above line.
There was a problem hiding this comment.
It was written in the iOS-paragraph, so I hoped people will get it's iOS related, but I'll explicitly say it :-).
| @@ -190,19 +191,6 @@ -(void)setType_:(id)type_ | |||
| } | |||
| } | |||
|
|
|||
| // We're order-dependent on type being set first, so we need to make sure that anything that relies | |||
| // on whether or not this is a date picker needs to be set AFTER the initial configuration. | |||
| -(void)setSelectionIndicator_:(id)value | |||
There was a problem hiding this comment.
Rather deleting the method , we should deprecate it by giving message to developers. What you think?
There was a problem hiding this comment.
It was not used since iOS 7 anyway, so I decided to clean up the core directly. Having it or not does not have an effect to the developer - they cannot disable the selection indicator anyway.
vijaysingh-axway
approved these changes
Apr 13, 2017
htbryant94
approved these changes
Apr 19, 2017
|
Reverting due to failing unit-tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24574