Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24574] (6_1_X) iOS: Fix picker-selection #8959

Merged
merged 2 commits into from Apr 19, 2017

Conversation

hansemannn
Copy link
Collaborator

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-// We're order-dependent on type being set first, so we need to make sure that anything that relies
-// on whether or not this is a date picker needs to be set AFTER the initial configuration.
--(void)setSelectionIndicator_:(id)value
-{

  • if (picker == nil) {
  •  [[self proxy] replaceValue:value forKey:@"selectionIndicator" notification:NO];
    
  • }
  • else if ([self isDatePicker]==NO)
  • {
  •  [(UIPickerView*)[self picker] setShowsSelectionIndicator:[TiUtils boolValue:value]];
    
  • }
    -}

Rather deleting the method , we should deprecate it by giving message to developers. What you think?

  •    Manually setting the property was deprecated in 6.1.0 and will be ignored by the SDK.
    

This is deprecated in iOS only. So iOS should be mentioned in above line.

@hansemannn
Copy link
Collaborator Author

See notes in the master-PR. Also, please try to format code with

\```objc
Code
\```

(Without the \)

@htbryant94 htbryant94 self-requested a review April 13, 2017 15:25
Copy link

@htbryant94 htbryant94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! picker selection indicator is now visible. Tested on iOS 10.2 / 9.3 Devices and Simulators.

@htbryant94 htbryant94 merged commit 163a432 into tidev:6_1_X Apr 19, 2017
@hansemannn
Copy link
Collaborator Author

Reverting due to failing unit-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants