Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24514] Android: Use https for Ti.Geolocation calls #8969

Merged
merged 3 commits into from Apr 18, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.2.0 milestone Apr 17, 2017
@frankieandone
Copy link
Contributor

@hansemannn, do you have a test case?

@hansemannn
Copy link
Collaborator Author

Any Ti.Geolocation.forwardGeocoder or Ti.Geolocation.reverseGeocoder call should trigger it. Try this:

var win = Ti.UI.createWindow({
    backgroundColor: '#fff'
});

var btn = Ti.UI.createButton({
    title: 'Trigger'
});

btn.addEventListener('click', function() {
    Ti.Geolocation.forwardGeocoder('Berlin, Germany', function(e) {
        alert(e);
    });
});

win.add(btn);
win.open();

@frankieandone
Copy link
Contributor

Thanks, CR && FR PASS.

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed; was able to trigger the Ti.Geolocation.forwardGeocoder from the test case provided above, I also checked the SDK build to ensure changes were actually made to the codebase.

Test Steps

  • Copied the test case from the description above
  • Pasted the test case in to a titanium project in JIRA
  • Ran the program on and Nexus 6P device running Android 7.1.2
  • Used JD-GUI to decompile the SDK build and verify that HTTP was changed to HTTPS in the code base in the following location android/modules/geolocation/src/java/ti/modules/titanium/geolocation/TiLocation.java

Screenshot of the event being triggered.
event-triggering

Environement
Appcelerator Command-Line Interface, version 6.1.0
Google Nexus 6P (Android 7.1.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir merged commit f10a9d2 into tidev:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants