[TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 #8970

frankieandone · 2017-04-17T18:46:27Z

Test Case:

Add this to tiapp.xml in your Titanium app directory.

<android>
	<manifest xmlns:android="http://schemas.android.com/apk/res/android">
		<uses-sdk android:targetSdkVersion="24"/>
	</manifest>
</android>

In titanium_mobile/build directory, run: node scons.js build && node scons.js package && node scons.js install. In your Titanium app, run and cat build/android/AndroidManifest.xml. Watch out for density flag in configChange attribute. Verify new flags are present. Then put window in split screen mode.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24570

hansemannn · 2017-04-17T19:17:57Z

android/cli/commands/_build.js

+		Object.keys(finalAndroidManifest.application.activity).forEach(function (name) {
+			var activity = finalAndroidManifest.application.activity[name];
+			if (!activity.configChanges) {
+				activity.configChanges = ['density'];


Is density the only possible value in configChanges? Otherwise it would break other configs. And we should warn them to put it there if they don't do so far.

No, there other values that go into configChanges but it is a requirement for consistency across different Android 7 devices for screen magnification. For activity.configChanges = ['density']; I used the same logic used elsewhere just in case a situation arises where configChanges is empty but the fact is screenSize will always be added to configChanges so it is kind of redundant in a way.

Also, I should make users aware that density is added by default?

The "density" configChange should always be injected into the AndroidManifest.xml for every activity when targeting Android 7.0 or higher.

If we do not add this configChange setting, then a Titanium activity's UI will disappear if the end-user changes the "Display Size" under Android's main "Settings/Display" screen.

The reason this happens is because apps targeting Android 7.0 (or higher) are expected to handle "Display Size" changes dynamically. If we do not override the "density" configChange, then the activity's onCreate() method will be called, which will wipe the UI we were previously displaying (the same behavior you would see if you were missing the "screenOrientation" configChange and you rotated the screen). Apps targeting an older OS version (ie: API Level) are force-quit and restarted instead when the "Display Size" changes.

jquick-axway · 2017-04-17T23:56:50Z

@fmerzadyan, can you double check if Titanium's JavaScript APIs correctly report the new "Display Size" set under Android "Settings/Display" please?
Ti.API.info("@@@ Screen Density: " + Ti.Platform.displayCaps.density); Ti.API.info("@@@ Screen DPI: " + Ti.Platform.displayCaps.dpi); Ti.API.info("@@@ Logical Density Factor: " + Ti.Platform.displayCaps.logicalDensityFactor);

Setting the "Display Size" to a larger setting will lower the DPI. For example, "xxxhdpi" to "mdpi" when setting it to the largest setting. We need to make sure that we're not caching the above properties since they can change dynamically now.

jquick-axway · 2017-04-20T20:02:30Z

@cb1kenobi, just to double check, is this the best way to inject this attribute setting to all activities in the AndroidManifest.xml file if the API Level is >= 24?
(The developer should not be able to remove it. It's required.)

jquick-axway · 2017-04-26T20:52:11Z

android/modules/platform/src/java/ti/modules/titanium/platform/DisplayCapsProxy.java

 			default :
-				return "medium";
+				return "unknown";


I gave you bad advise. It should not return "unknown". Developers use this name to load images of an appropriate size based on the "density" name property. So, this code needs to be changed to use >= checks. It should also not return "medium" for unknown densities either.

The code should be changed to something like this...

public String getDensity() { synchronized(dm) { getDisplay().getMetrics(dm); int dpi = dm.densityDpi; if (dpi >= 560) { // DisplayMetrics.DENSITY_560 return "xxxhigh"; } else if (dpi >= 400) { // DisplayMetrics.DENSITY_400 return "xxhigh"; } else if (dpi >= 280) { // DisplayMetrics.DENSITY_280 return "xhigh"; } else if (dpi >= DisplayMetrics.DENSITY_HIGH) { return "high"; } else if (dpi >= DisplayMetrics.DENSITY_TV) { return "tvdpi"; } else if (dpi >= DisplayMetrics.DENSITY_MEDIUM) { return "medium"; } return "low"; } }

jquick-axway · 2017-04-26T20:55:22Z

android/cli/commands/_build.js

-	if (this.realTargetSDK >= 13) {
+	if (this.realTargetSDK >= 24 && !finalAndroidManifest.application.hasOwnProperty('resizeableActivity')) {
+		finalAndroidManifest.application.resizeableActivity = true;
+	}


Let's remove this from "_build.js". We don't want to force developers to use "resizeableActivity" in case they have layout issues when sized too small in a split-screen window... in which case they can opt-out by setting this attribute to false in the "tiapp.xml" file.

^ Never mind. Your code is checking for the existence of the property. It's doing it right.

jquick-axway

Approved

lokeshchdhry · 2017-07-10T21:40:47Z

@fmerzadyan , I am seeing an issue where app built with this fix has an invalid Androidmanifest.xml.

<?xml version="1.0" encoding="UTF-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.app.timob24570" android:versionCode="1" android:versionName="1.0">
	<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="24"/>
	<application android:icon="@drawable/appicon" android:label="TIMOB-24570" android:name="Timob24570Application" android:debuggable="false" android:theme="@style/Theme.AppCompat" android:resizeableActivity="true">
		<activity android:name=".Timob24570Activity" android:label="@string/app_name" android:theme="@style/Theme.Titanium" android:configChanges="keyboardHidden|orientation|fontScale|screenSize|smallestScreenSize|screenLayout|density"/>
		<service android:name="com.appcelerator.aps.APSAnalyticsService" android:exported="false"/>
	</application>
	<uses-permission android:name="android.permission.INTERNET"/>
	<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
	<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
</manifest>

This is causing the app to get installed but not launch or show up in the apps list on the device.

Studio Ver: 4.9.0.201705302345
SDK Ver: 6.2.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

…ndow in Android 7.0

lokeshchdhry · 2017-07-17T18:58:13Z

FR Passed.

The app switches as expected to split screen to normal mode & vice versa. Also, changing the display size in the settings appropriately reflects the change in the app but, this change is only seen when the app is restarted & not when the app is resumed from paused state or from background.
Confirmed with @jquick-axway about this behavior as we do not have a event like e.g resize for the app to change its UI/display size on the fly.
Also, the split screen mode works as expected. The app can be put in split screen mode & its screen size can be increased or decreased.

Studio Ver: 4.9.1.201707130742
SDK Ver: 6.2.0.v20170713162837 from PR
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Device: Pixel Android 7.0
Emulator: Android 7.0, android 7.1.1

frankieandone added android feature labels Apr 17, 2017

frankieandone self-assigned this Apr 17, 2017

frankieandone requested a review from jquick-axway April 17, 2017 18:46

hansemannn reviewed Apr 17, 2017

View reviewed changes

garymathews changed the title ~~timob-24570 address Android N: breaking screen density breaking changes~~ [TIMOB-24570] Android: Fix screen density breaking changes in Android 7.0 Apr 20, 2017

jquick-axway requested a review from cb1kenobi April 20, 2017 19:58

frankieandone force-pushed the timob-24570 branch 3 times, most recently from 71cf57f to 63f946e Compare April 26, 2017 17:12

frankieandone changed the title ~~[TIMOB-24570] Android: Fix screen density breaking changes in Android 7.0~~ [TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 Apr 26, 2017

frankieandone mentioned this pull request Apr 26, 2017

[TIMOB-24501] Android: multi-window support #8925

Closed

frankieandone force-pushed the timob-24570 branch from 34a07e7 to 9ed6cea Compare April 26, 2017 18:23

jquick-axway reviewed Apr 26, 2017

View reviewed changes

frankieandone force-pushed the timob-24570 branch 2 times, most recently from c65e317 to 7266e2b Compare April 26, 2017 22:25

jquick-axway approved these changes Apr 26, 2017

View reviewed changes

jquick-axway added the in-qe-testing 🕵 label Apr 27, 2017

jquick-axway removed the request for review from cb1kenobi April 27, 2017 17:22

hansemannn added this to the 6.2.0 milestone Jun 5, 2017

frankieandone force-pushed the timob-24570 branch from 7a84396 to 49942ca Compare June 30, 2017 17:28

[TIMOB-24570] Android: Fix screen density breaking changes + multi-wi…

6eeb715

…ndow in Android 7.0

frankieandone force-pushed the timob-24570 branch from 49942ca to 6eeb715 Compare July 13, 2017 21:46

Merge branch 'master' into timob-24570

88cf466

Merge branch 'master' into timob-24570

724f631

lokeshchdhry merged commit 17297eb into tidev:master Jul 17, 2017

This was referenced Aug 1, 2017

(6_2_0)[TIMOB-24570] Android: Re-add density to list of attributes #9269

Merged

[TIMOB-24570] Android: Re-add density to list of attributes #9270

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 #8970

[TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 #8970

frankieandone commented Apr 17, 2017 •

edited

hansemannn Apr 17, 2017

frankieandone Apr 17, 2017 •

edited

jquick-axway Apr 17, 2017 •

edited

jquick-axway commented Apr 17, 2017

jquick-axway commented Apr 20, 2017

jquick-axway Apr 26, 2017 •

edited

jquick-axway Apr 26, 2017 •

edited

jquick-axway left a comment

lokeshchdhry commented Jul 10, 2017

lokeshchdhry commented Jul 17, 2017 •

edited

[TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 #8970

[TIMOB-24570] Android: Fix screen density breaking changes + multi-window in Android 7.0 #8970

Conversation

frankieandone commented Apr 17, 2017 • edited

Test Case:

hansemannn Apr 17, 2017

Choose a reason for hiding this comment

frankieandone Apr 17, 2017 • edited

Choose a reason for hiding this comment

jquick-axway Apr 17, 2017 • edited

Choose a reason for hiding this comment

jquick-axway commented Apr 17, 2017

jquick-axway commented Apr 20, 2017

jquick-axway Apr 26, 2017 • edited

Choose a reason for hiding this comment

jquick-axway Apr 26, 2017 • edited

Choose a reason for hiding this comment

jquick-axway left a comment

Choose a reason for hiding this comment

lokeshchdhry commented Jul 10, 2017

lokeshchdhry commented Jul 17, 2017 • edited

frankieandone commented Apr 17, 2017 •

edited

frankieandone Apr 17, 2017 •

edited

jquick-axway Apr 17, 2017 •

edited

jquick-axway Apr 26, 2017 •

edited

jquick-axway Apr 26, 2017 •

edited

lokeshchdhry commented Jul 17, 2017 •

edited