New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate titanium-sdk node module to it's own repository #8974
Conversation
So why don't we just publish |
@cb1kenobi yeah, I agree, I don't like referring git repos and branches either. We should version this and everything. I just wasn't sure if there was any reason we couldn't publish it, and I was guessing we wanted to rename it in some way. |
After doing some thinking, I feel we should name this |
…istry. Move node_modules/titanium-sdk to node_modules/node-titanium-sdk
d7875b8
to
fed320e
Compare
@cb1kenobi I renamed the repo and npm module to be |
@sgtcoolguy Awesome! Thank you for doing this! I would like to merge this before #8972, however since you modified |
@cb1kenobi Sounds good to me. I've ported the jsanalyze changes to tidev/node-titanium-sdk#1 So we can merge this one and then that PR, and then I can update #8972 to simply update the node-titanium-sdk version. |
* Move titanium-sdk out to a separate repo * Grab titanium-sdk dependency from separate git repo * Rename titanium-sdk module to node-titanium-sdk, grab it from npm registry. Move node_modules/titanium-sdk to node_modules/node-titanium-sdk * Point to node-titanium-sdk on npm registry
We currently have one special node module dependency which actually only lives inside the SDK's node_modules folder. This PR "moves out" the dependency to it's own repository at appcelerator/titanium-sdk. It doesn't attempt to grab it from the npm package registry, but simply uses a Git URI to point at master branch of the repo.
This is in preparation for a potential future change to try and use yarn/yarn.lock instead of packaging the full node_modules folder in the SDK repo itself (https://jira.appcelerator.org/browse/TIMOB-24591)