Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate titanium-sdk node module to it's own repository #8974

Merged
merged 4 commits into from Apr 24, 2017

Conversation

sgtcoolguy
Copy link
Contributor

We currently have one special node module dependency which actually only lives inside the SDK's node_modules folder. This PR "moves out" the dependency to it's own repository at appcelerator/titanium-sdk. It doesn't attempt to grab it from the npm package registry, but simply uses a Git URI to point at master branch of the repo.

This is in preparation for a potential future change to try and use yarn/yarn.lock instead of packaging the full node_modules folder in the SDK repo itself (https://jira.appcelerator.org/browse/TIMOB-24591)

@sgtcoolguy sgtcoolguy added this to the 6.2.0 milestone Apr 19, 2017
@cb1kenobi
Copy link
Contributor

cb1kenobi commented Apr 19, 2017

So why don't we just publish titanium-sdk to NPM? I don't like referencing git repos unless we absolutely need to. I also think we should discuss changing the name to perhaps node-tisdk or something since it's just a library.

@sgtcoolguy
Copy link
Contributor Author

@cb1kenobi yeah, I agree, I don't like referring git repos and branches either. We should version this and everything. I just wasn't sure if there was any reason we couldn't publish it, and I was guessing we wanted to rename it in some way.

@cb1kenobi
Copy link
Contributor

After doing some thinking, I feel we should name this node-tisdk or node-titanium-sdk. This is a Node specific library and thus node- prefix seems appropriate. Other than that, I'm fine with moving it out into a separate repo.

@sgtcoolguy
Copy link
Contributor Author

@cb1kenobi I renamed the repo and npm module to be node-titanium-sdk and made myself, you and appcelerator as owners on the registry. I updated this PR to point to the module on the npm registry rather than the git repo.

@cb1kenobi
Copy link
Contributor

@sgtcoolguy Awesome! Thank you for doing this!

I would like to merge this before #8972, however since you modified node_modules/titanium-sdk/lib/jsanalyze.js in #8972, you should just update jsanalyze.js in node-titanium-sdk with the Babel changes. This also means the babylon, babel-core, babel-preset-babili, babel-traverse, and babel-types as NPM dependencies should go in node-titanium-sdk, not in titanium_mobile. #8972 effectively becomes a simple update of node-titanium-sdk to v0.2.0.

@sgtcoolguy
Copy link
Contributor Author

@cb1kenobi Sounds good to me. I've ported the jsanalyze changes to tidev/node-titanium-sdk#1

So we can merge this one and then that PR, and then I can update #8972 to simply update the node-titanium-sdk version.

@sgtcoolguy sgtcoolguy merged commit 28810c9 into tidev:master Apr 24, 2017
@sgtcoolguy sgtcoolguy deleted the npm-titanium-sdk branch April 24, 2017 17:37
lokeshchdhry pushed a commit to lokeshchdhry/QEUtility-Node that referenced this pull request Apr 27, 2017
sgtcoolguy added a commit to sgtcoolguy/titanium_mobile that referenced this pull request May 4, 2017
* Move titanium-sdk out to a separate repo

* Grab titanium-sdk dependency from separate git repo

* Rename titanium-sdk module to node-titanium-sdk, grab it from npm registry. Move node_modules/titanium-sdk to node_modules/node-titanium-sdk

* Point to node-titanium-sdk on npm registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants