Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24607] Android: stop network connectivity change event firing at start #8981

Merged
merged 5 commits into from May 15, 2017
Merged

[TIMOB-24607] Android: stop network connectivity change event firing at start #8981

merged 5 commits into from May 15, 2017

Conversation

frankieandone
Copy link
Contributor

Test Case:

Expect to not see test msg: change event in log output on application start up. Turn wifi on/off. Expect to see message in logs.

Ti.Network.addEventListener("change", function(e) {
	console.log("test msg: change event")
});

JIRA: https://jira.appcelerator.org/browse/TIMOB-24607

@frankieandone frankieandone self-assigned this Apr 20, 2017
jquick-axway
jquick-axway approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

hansemannn
hansemannn requested changes Apr 20, 2017
View reviewed changes
android/modules/network/src/java/ti/modules/titanium/network/TiNetworkListener.java Outdated
if (!init) {
init = true;
return;
}
String action = intent.getAction();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@longton95 longton95 self-requested a review May 10, 2017 15:47
longton95
longton95 approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested using the test case above, the change event is not fired on creation.

ENV

SDK Version : Local 6.2.0
Mac OS Version : 10.12.4
Appc CLI : 6.2.1
Appc NPM : 4.2.9
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.2)
Emulator: (6.0), (4.4.2)

@longton95 longton95 merged commit 91d38e4 into tidev:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn requested changes

@longton95 longton95 longton95 approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees

@frankieandone frankieandone

Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frankieandone @longton95 @hansemannn @jquick-axway @sgtcoolguy