Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24460] Android: Fix TextField with passwordMask fires unwanted change event #8983

Merged
merged 4 commits into from May 10, 2017
Merged

[TIMOB-24460] Android: Fix TextField with passwordMask fires unwanted change event #8983

merged 4 commits into from May 10, 2017

Conversation

maggieaxway
Copy link
Contributor

@maggieaxway maggieaxway commented Apr 21, 2017

[TIMOB-24460] Android: Fix TextField with passwordMask fires unwanted
change event

JIRA: https://jira.appcelerator.org/browse/TIMOB-24460

Test Case:

var win = Ti.UI.createWindow({backgroundColor : 'gray', layout: 'vertical'}),
    tf = Ti.UI.createTextField({
        value: 'TEXT',
        passwordMask: true

    }),
    btn = Ti.UI.createButton({title: 'TOGGLE passwordMask'});

tf.addEventListener('change', function() {
    alert('TEXT CHANGED');
});

btn.addEventListener('click', function() {
    tf.passwordMask = !tf.passwordMask;
});

win.add(tf);
win.add(btn);

win.open();

[TIMOB-24460] Android: Fix TextField with passwordMask fires unwanted
`change` event
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS
FT: PASS

@garymathews garymathews added this to the 6.2.0 milestone Apr 22, 2017
@ssjsamir ssjsamir requested review from ssjsamir and removed request for ssjsamir April 24, 2017 18:20
@longton95 longton95 self-requested a review April 27, 2017 15:09
@longton95
Copy link
Contributor

longton95 commented Apr 27, 2017

@maggieaxway The change event is not fired on creation but the event is still fired when passwordMask is changed.

The event is not fired on iOS when passwordMask changed

@maggieaxway
Copy link
Contributor Author

@longton95 Yes I noticed that. I have another PR for it. Will update together when fixed other bugs.

Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested using the test case above and a modified version, the change event is not fired on creation.

ENV

SDK Version : Local 6.2.0
Mac OS Version : 10.12.4
Appc CLI : 6.2.0
Appc NPM : 4.2.9
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.2)
Emulator: (6.0), (4.4.2)

@longton95 longton95 merged commit 4bd780f into tidev:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants