Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24617] Fix SDK build and package of Android on Windows #8984

Merged
merged 2 commits into from Apr 24, 2017
Merged

[TIMOB-24617] Fix SDK build and package of Android on Windows #8984

merged 2 commits into from Apr 24, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Apr 21, 2017 •
edited

NOTE: test with #8679
TEST CASE
cd build
node scons.js build android
node scons.js package

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone Apr 21, 2017
@sgtcoolguy sgtcoolguy merged commit 4194ed4 into tidev:master Apr 24, 2017
@sgtcoolguy
Copy link
Contributor

Oops, didn't see that you request @ypbnv 's review as well. Oh well, LGTM. Merged to master.

@ingo
Copy link
Contributor

ingo commented Apr 24, 2017

I think we should add a note that these are only to be used in packaging, and NOT shipped with the SDK (as they are GPL). This will come up on some security scan at some point.

@garymathews garymathews mentioned this pull request Apr 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

@ypbnv ypbnv Awaiting requested review from ypbnv

Assignees
No one assigned
Labels
android improvement
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @sgtcoolguy @ingo