[TIMOB-24629] Android: Add Notification wakeLock #8990

m1ga · 2017-04-25T18:47:10Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-24629

Example:

var win = Ti.UI.createWindow({});
var btn = Ti.UI.createButton({
	title: "click"
});
win.add(btn);

btn.addEventListener("click", function() {
	_.delay(function() {
		var intent = Ti.Android.createIntent({
			action: Ti.Android.ACTION_MAIN,
			className: 'com.appcelerator.notificationsample.NotificationsampleActivity',
			packageName: 'com.appcelerator.notificationsample'
		});
		intent.flags |= Ti.Android.FLAG_ACTIVITY_CLEAR_TOP | Ti.Android.FLAG_ACTIVITY_NEW_TASK;
		intent.addCategory(Ti.Android.CATEGORY_LAUNCHER);

		var pending = Titanium.Android.createPendingIntent({
			intent: intent,
			flags: Titanium.Android.FLAG_UPDATE_CURRENT
		});

		var notification = Titanium.Android.createNotification({
			contentTitle: 'Something Happened',
			contentText: 'Click to return to the application.',
			contentIntent: pending, 
			wakeLock: {
				time: 2000,
				flags: Ti.Android.WAKE_LOCK_PARTIAL | Ti.Android.WAKE_LOCK_ON_AFTER_RELEASE
			}
		});
		Titanium.Android.NotificationManager.notify(1, notification);
	}, 4000);
});

win.open();

hansemannn · 2017-04-26T08:02:15Z

apidoc/Titanium/Android/Notification.yml

+    summary: Will wake up the device for the given time (in milliseconds) when the notification is shown.
+        The application needs to also set the `android.permission.WAKE_LOCK` permission
+        in the Android manifest section of the `tiapp.xml` file.
+


Replace with:

summary: | Will wake up the device for the given time (in milliseconds) when the notification is shown. The application needs to also set the `android.permission.WAKE_LOCK` permission in the Android manifest section of the `tiapp.xml` file.

hansemannn · 2017-04-26T08:04:12Z

...roid/src/java/ti/modules/titanium/android/notificationmanager/NotificationManagerModule.java

+			boolean isScreenOn = pm.isScreenOn();
+			if(isScreenOn==false) {
+				WakeLock wl = pm.newWakeLock(PowerManager.FULL_WAKE_LOCK | PowerManager.ACQUIRE_CAUSES_WAKEUP | PowerManager.ON_AFTER_RELEASE, "MyWakeLock");
+    			wl.acquire(wakeTime);


Indentation in 86 and space in ){. Maybe rename MyWakeLock to TiWakeLock.

garymathews · 2017-04-26T10:18:54Z

...roid/src/java/ti/modules/titanium/android/notificationmanager/NotificationManagerModule.java


 import ti.modules.titanium.android.AndroidModule;
 import android.app.Activity;
 import android.app.Notification;
 import android.app.NotificationManager;
+import android.os.PowerManager;
+import android.os.PowerManager.WakeLock;
+


Also remove this extra line :)

hansemannn · 2017-04-26T10:21:36Z

...roid/src/java/ti/modules/titanium/android/notificationmanager/NotificationManagerModule.java

+		if (wakeTime > 0){
+			PowerManager pm = (PowerManager)TiApplication.getInstance().getSystemService(TiApplication.getInstance().getApplicationContext().POWER_SERVICE);
+			boolean isScreenOn = pm.isScreenOn();
+			if(isScreenOn==false) {


Same here btw: Spaces spaces spaces 👾

m1ga · 2017-04-26T19:10:04Z

Change the parameter to accept a HashMap like this: wakeLock:{time: 1000, flag: Ti.Android.PARTIAL_WAKE_LOCK} to be more flexible.

hansemannn · 2017-04-27T06:27:03Z

apidoc/Titanium/Android/Notification.yml

+        Titanium.Android.PARTIAL_WAKE_LOCK | Titanium.Android.FULL_WAKE_LOCK | 
+        Titanium.Android.SCREEN_DIM_WAKE_LOCK | Titanium.Android.SCREEN_BRIGHT_WAKE_LOCK
+        Titanium.Android.ACQUIRE_CAUSES_WAKEUP | Titanium.Android.ON_AFTER_RELEASE
+    default: Titanium.Android.FULL_WAKE_LOCK | Titanium.Android.ACQUIRE_CAUSES_WAKEUP | Titanium.Android.ON_AFTER_RELEASE


We usually prefix the constants so it's easier to find and group them. For example:

WAKE_LOCK_PARTIAL

WAKE_LOCK_FULL

WAKE_LOCK_SCREEN_DIM

Then you could also also write constants: [Titanium.Android_WAKE_LOCK_*]

Ah, nice! I've made the changes.

hansemannn · 2017-04-27T16:18:27Z

apidoc/Titanium/Android/Notification.yml

+  - name: flags
+    summary: Wake lock level and flag. See [Android Developers: PowerManager](https://developer.android.com/reference/android/os/PowerManager.html#newWakeLock(int,%20java.lang.String))
+    type: int
+    constants: [Titanium.Android_WAKE_LOCK_*]


Titanium.Android_WAKE_LOCK_* -> Titanium.Android.WAKE_LOCK_*

hansemannn · 2017-04-27T16:19:06Z

android/modules/android/src/java/ti/modules/titanium/android/AndroidModule.java

+	@Kroll.constant public static final int WAKE_LOCK_SCREEN_DIM = PowerManager.SCREEN_DIM_WAKE_LOCK;
+	@Kroll.constant public static final int WAKE_LOCK_SCREEN_BRIGHT = PowerManager.SCREEN_BRIGHT_WAKE_LOCK;
+	@Kroll.constant public static final int WAKE_LOCK_ACQUIRE_CAUSES_WAKEUP = PowerManager.ACQUIRE_CAUSES_WAKEUP;
+	@Kroll.constant public static final int WAKE_LOCK_ON_AFTER_RELEASE = PowerManager.ON_AFTER_RELEASE;


Missing docs for the constants?

missing file :-)

hansemannn · 2017-04-28T04:59:07Z

LGTM! @garymathews for an additional review.

hansemannn · 2017-05-20T14:24:49Z

@m1ga You closed the PR? :(

m1ga · 2017-05-20T14:39:35Z

oh sorry. closed the wrong branch

garymathews

CR: PASS

Conflict needs fixing though

hansemannn · 2017-08-11T16:37:56Z

I think my latest resolve of the merge-conflicts screw up around here. Also, the backport #9307 has a different number of lines and removed the dragstart event-key from the code, no idea why (it was only removed in an earlier commit but restored later). So we need to check those issue first before giving it to QE.

lokeshchdhry · 2017-08-22T22:28:30Z

@garymathews , @m1ga ,
I am having issues when I try to test. I am checking with the above code.
It works fine with flags: Ti.Android.PARTIAL_WAKE_LOCK, but not with any other flag. The screen does not turn on at full brightness or in dim state when the notification arrives.
Also, for flag flags: Ti.Android.WAKE_LOCK_ACQUIRE_CAUSES_WAKEUP I am getting the below errors:

[WARN] :   W/System.err: java.lang.IllegalArgumentException: Must specify a valid wake lock level.
[WARN] :   W/System.err: 	at android.os.PowerManager.validateWakeLockParameters(PowerManager.java:517)
[WARN] :   W/System.err: 	at android.os.PowerManager.newWakeLock(PowerManager.java:501)
[WARN] :   W/System.err: 	at ti.modules.titanium.android.notificationmanager.NotificationManagerModule.notify(NotificationManagerModule.java:89)
[WARN] :   W/System.err: 	at org.appcelerator.kroll.runtime.v8.V8Function.nativeInvoke(Native Method)
[WARN] :   W/System.err: 	at org.appcelerator.kroll.runtime.v8.V8Function.callSync(V8Function.java:57)
[WARN] :   W/System.err: 	at org.appcelerator.kroll.runtime.v8.V8Function.call(V8Function.java:43)
[WARN] :   W/System.err: 	at ti.modules.titanium.TitaniumModule$Timer.run(TitaniumModule.java:147)
[WARN] :   W/System.err: 	at android.os.Handler.handleCallback(Handler.java:739)
[WARN] :   W/System.err: 	at android.os.Handler.dispatchMessage(Handler.java:95)
[WARN] :   W/System.err: 	at android.os.Looper.loop(Looper.java:148)
[WARN] :   W/System.err: 	at android.app.ActivityThread.main(ActivityThread.java:5417)
[WARN] :   W/System.err: 	at java.lang.reflect.Method.invoke(Native Method)
[WARN] :   W/System.err: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
[WARN] :   W/System.err: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
[ERROR] :  TiExceptionHandler: (main) [4352,4352] ----- Titanium Javascript Runtime Error -----
[ERROR] :  TiExceptionHandler: (main) [0,4352] - In /app.js:31,40
[ERROR] :  TiExceptionHandler: (main) [1,4353] - Message: Uncaught Must specify a valid wake lock level.
[ERROR] :  TiExceptionHandler: (main) [0,4353] - Source: 		Titanium.Android.NotificationManager.notify(1, notification);
[ERROR] :  V8Exception: Exception occurred at /app.js:31: Uncaught Must specify a valid wake lock level.
[ERROR] :  V8Exception: Must specify a valid wake lock level.

lokeshchdhry · 2017-08-22T22:30:48Z

Failing FR for now.

m1ga · 2017-08-23T05:54:28Z

ACQUIRE_CAUSES_WAKEUP and ON_AFTER_RELEASE are flags you can add to the WAKE_LOCK levels. See https://developer.android.com/reference/android/os/PowerManager.html
I'll implement a check so it will show an error instead of the crash

Catch exception and show message

lokeshchdhry · 2017-08-23T18:48:32Z

@m1ga , Thanks for the link I was using the flags in a wrong way. It works fine. But with flag WAKE_LOCK_SCREEN_BRIGHT & WAKE_LOCK_FULL the screen turns ON but not at the full brightness.

garymathews · 2017-08-23T19:11:27Z

@lokeshchdhry here's another test case

var win = Ti.UI.createWindow({
        title: 'TIMOB-24629',
        backgroundColor: 'gray'
    }),
    btn = Ti.UI.createButton({
        title: 'START',
        width: '33%'
    }),
    ntn = Titanium.Android.createNotification({
        contentTitle: 'WAKE-LOCK TEST',
        contentText: 'Do nothing...',
        wakeLock: {
            time: 3000,
            flags: Ti.Android.WAKE_LOCK_FULL | Ti.Android.WAKE_LOCK_ACQUIRE_CAUSES_WAKEUP | Ti.Android.WAKE_LOCK_ON_AFTER_RELEASE
        }
    });

btn.addEventListener('click', function() {
    var i = 4,
        interval = setInterval(function() {
            btn.setTitle('COUNT ' + --i);
            if (i <= 0) {
                Ti.Android.NotificationManager.notify(1, ntn);
                clearInterval(interval);
                btn.setTitle('START');
                btn.setEnabled(true);
            }
        }, 1000);
    btn.setEnabled(false);
    btn.setTitle('COUNT ' + --i);
});

win.add(btn);
win.open();

lokeshchdhry · 2017-08-23T20:43:46Z

Thanks @garymathews , I was using the flags in a wrong way. But, as I have commented above with flag WAKE_LOCK_SCREEN_BRIGHT & WAKE_LOCK_FULL the screen turns ON but not at the full brightness.
Is this expected ?

garymathews · 2017-08-23T21:33:23Z

@lokeshchdhry I would say it's expected behaviour since the flags are being set correctly, that behaviour is dictated by Android.

lokeshchdhry · 2017-08-23T22:17:17Z

@garymathews , Ok sounds good.

m1ga changed the title ~~[AC-4926] Notification wake lock~~ [AC-4926] Android: Notification wakeLock Apr 25, 2017

hansemannn changed the title ~~[AC-4926] Android: Notification wakeLock~~ [TIMOB-24629] Android: Add Notification wakeLock Apr 26, 2017

hansemannn requested changes Apr 26, 2017

View reviewed changes

garymathews reviewed Apr 26, 2017

View reviewed changes

hansemannn added android community 🔥 feature labels Apr 26, 2017

hansemannn added this to the 6.2.0 milestone Apr 26, 2017

hansemannn reviewed Apr 26, 2017

View reviewed changes

hansemannn reviewed Apr 27, 2017

View reviewed changes

hansemannn requested changes Apr 27, 2017

View reviewed changes

hansemannn approved these changes Apr 28, 2017

View reviewed changes

m1ga closed this May 20, 2017

m1ga deleted the notificationWakeLock branch May 20, 2017 08:31

m1ga restored the notificationWakeLock branch May 20, 2017 14:34

m1ga reopened this May 20, 2017

garymathews approved these changes Aug 11, 2017

View reviewed changes

hansemannn added in-qe-testing 🕵 and removed in-qe-testing 🕵 labels Aug 11, 2017

[TIMOB-24629] Implement notification wakeLock parameter

15e362b

garymathews force-pushed the notificationWakeLock branch from 2390370 to 15e362b Compare August 14, 2017 11:16

[TIMOB-24629] Cleanup

c13e2e1

garymathews force-pushed the notificationWakeLock branch from 3c311de to c13e2e1 Compare August 14, 2017 11:35

garymathews added the in-qe-testing 🕵 label Aug 14, 2017

hansemannn added this to the 7.0.0 milestone Aug 15, 2017

hansemannn removed this from the 6.2.0 milestone Aug 15, 2017

Merge branch 'master' into notificationWakeLock

5249767

Update NotificationManagerModule.java

8f5dde3

Catch exception and show message

Lokesh Choudhary added 2 commits August 23, 2017 15:17

Merge branch 'master' into notificationWakeLock

092852f

Merge branch 'master' into notificationWakeLock

996be92

lokeshchdhry merged commit 41fda02 into tidev:master Aug 23, 2017

m1ga deleted the notificationWakeLock branch September 9, 2017 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-24629] Android: Add Notification wakeLock #8990

[TIMOB-24629] Android: Add Notification wakeLock #8990

m1ga commented Apr 25, 2017 •

edited

hansemannn Apr 26, 2017

hansemannn Apr 26, 2017

garymathews Apr 26, 2017

hansemannn Apr 26, 2017

m1ga commented Apr 26, 2017

hansemannn Apr 27, 2017

m1ga Apr 27, 2017

hansemannn Apr 27, 2017

hansemannn Apr 27, 2017

m1ga Apr 27, 2017

hansemannn commented Apr 28, 2017 •

edited

hansemannn commented May 20, 2017

m1ga commented May 20, 2017

garymathews left a comment •

edited

hansemannn commented Aug 11, 2017

lokeshchdhry commented Aug 22, 2017

lokeshchdhry commented Aug 22, 2017

m1ga commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

garymathews commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

garymathews commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

[TIMOB-24629] Android: Add Notification wakeLock #8990

[TIMOB-24629] Android: Add Notification wakeLock #8990

Conversation

m1ga commented Apr 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1ga commented Apr 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn commented Apr 28, 2017 • edited

hansemannn commented May 20, 2017

m1ga commented May 20, 2017

garymathews left a comment • edited

Choose a reason for hiding this comment

hansemannn commented Aug 11, 2017

lokeshchdhry commented Aug 22, 2017

lokeshchdhry commented Aug 22, 2017

m1ga commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

garymathews commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

garymathews commented Aug 23, 2017

lokeshchdhry commented Aug 23, 2017

m1ga commented Apr 25, 2017 •

edited

hansemannn commented Apr 28, 2017 •

edited

garymathews left a comment •

edited