[6_1_X][TIMOB-20247] Regression in android HTTPClient #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send ready state after getting the headers and the status. Change indentation.
garymathews
changed the title
garymathews
reviewed
May 2, 2017
| } | ||
|
|
||
| // If no charset is defined, default to UTF-8 | ||
| if ("".equals(charset)) { |
There was a problem hiding this comment.
Could probably optimise this if statement while making changes here
if (charset.isEmpty()) {
ssjsamir
approved these changes
May 10, 2017
There was a problem hiding this comment.
Master: #8997
FR Passed: Was able to get a response using the test case provided in https://jira.appcelerator.org/browse/TIMOB-20247 without getting any errors.
Test steps
- Built the SDK form this PR
- Copied the test case from the description in https://jira.appcelerator.org/browse/TIMOB-20247
var xhr = Titanium.Network.createHTTPClient();
xhr.onreadystatechange = function() {
if (3 == xhr.readyState) {
console.log(xhr.getResponseHeader('Last-Modified'));
}
};
xhr.open('GET', 'http://www.appcelerator.com/assets/The_iPad_App_Wave.pdf');
xhr.send();
- Pasted the code in to a titanium project
- Ran the program
- Saw the following response in the console and application showed no errors
[INFO] : Thu, 04 May 2017 16:24:20 GMT
[INFO] : Thu, 04 May 2017 16:24:20 GMT
Environment
Appcelerator Command-Line Interface, version 6.2.0
Samsung Galaxy S4 (Running android 4.4.4)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send ready state after getting the headers and the status. Change indentation.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20247