[TIMOB-24297] Android: NDK r13c and r14b compatibility #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lates, so the Set*Method calls needed to set the generated FunctionTemplate (and not it's function). Also need to hack around hanging an External wrapping a jclass on the __javaClass_ property by using a natiev data property getter callback that gets the External passed as Data and returning that.
…gher version/moduleApiVersion against a build of the SDK
…mplate must be throwing some uncaught excpetion, so the toLocalChecked() on GetFunction is failing.
…with a proxy that we then go back and kill the proxy/JS object on the C++ side. Tehre's still an issue here where we're not cleaning up jclass references somehow that I need to fix...
…undary to Proxy instances
…hey don't *all* barf/crash
garymathews
force-pushed
the
TIMOB-24297
branch
from
a1a7f2e
to
8605e88
Compare
|
Also a note that as of V8 5.7.492.71, the "legacy" debugger seemed to work fine. I've opened https://jira.appcelerator.org/browse/TIMOB-24723 to track updating our JSDebugger shim to speak to the V8 inspector APIs and use web sockets as the carrying protocol so that 3rd party tools like Chrome Devtools can be used to debug apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from [TIMOB-23903] Build against V8 5.7.492.71 #8382 (merge first)
Suppress warnings from compiling with NDK r14b
Fix native module bootstrap template syntax
Bump V8 version to
5.7.54.0NOTE:
libv8-5.7.54.0-release.tar.bz2is not yet on AWSJIRA Ticket