Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24647] Android: Also set constructor values in KrollRuntime #9005

Merged
merged 2 commits into from Jul 19, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented May 2, 2017

NOTE: This may only be an issue when using IntelliJ
  • Set constructor values in both Java and KrollRuntime
TEST CASE
var win = Ti.UI.createWindow({backgroundColor : 'gray', layout: 'vertical'}),
    tf = Ti.UI.createTextField({
        value: 'TEXT',
        passwordMask: true
    }),
    btn = Ti.UI.createButton({title: 'passwordMask VALUE'});
 
btn.addEventListener('click', function() {
    // passwordMask should be 'true'
    Ti.API.info('passwordMask: ' + tf.passwordMask);
});
 
win.add(tf);
win.add(btn);
 
win.open();

JIRA Ticket

Copy link
Contributor

@maggieaxway maggieaxway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR PASS FT PASS

@ssjsamir ssjsamir requested review from ssjsamir and removed request for ssjsamir May 2, 2017 17:10
@frankieandone
Copy link
Contributor

FR Passed: The test was carried out on IntelliJ. passwordMask: true was seen in the logs when running this branch. passwordMask: undefined when run on master (without the changes). But when using AppC CLI, passwordMask: true was seen when running 6.1.1.GA (without the changes).

Test Environment:

Operating System

Name = Mac OS X
Version = 10.12.5
Architecture = 64bit
CPUs = 8
Memory = 16.0GB

Node.js

Node.js Version = 4.5.0
npm Version = 4.2.0

Appcelerator CLI

Installer = 4.2.8
Core Package = 6.2.2

Titanium CLI

CLI Version = 5.0.14
node-appc Version = 0.2.41

IntelliJ Version = 2017.1

@frankieandone frankieandone merged commit 059a46c into tidev:master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants