[6_1_0][TIMOB-24181] Android: fix ListItem template property inconsistencies

[frankieandone]

TEST CASE

var win = Ti.UI.createWindow({
	title: "classic_app",
	backgroundColor: "#000"
});

var customListItemTemplate = {
	properties: {
		name: "template",
		accessoryType: Ti.UI.LIST_ACCESSORY_TYPE_DISCLOSURE,
		backgroundColor: "red"
	},
	childTemplates: [
		{
			type: "Ti.UI.Label",
			bindId: "title",
			properties: {
				bindId: "title"
			}
		}
	]
};
var listView = Ti.UI.createListView({
	templates: {
		"template": customListItemTemplate
	},
	defaultItemTemplate: "template"
});

var sectionArray = [], sectionOne, itemArray = [], itemOne;
itemOne = {
	properties: {
		accessoryType: undefined,
		backgroundColor: undefined
	},
	title: {
		text: "itemOne title"
	}
};
itemArray.push(itemOne);
sectionOne = Ti.UI.createListSection({
	headerTitle: "Section title #1",
	items: itemArray
});
sectionArray.push(sectionOne);
listView.setSections(sectionArray);

win.add(listView);
win.open();

EXPECTED
Should get red background for list item.

JIRA: https://jira.appcelerator.org/browse/TIMOB-24181

[mukherjee2]

FAILED FR with this environment:
Node Version: 6.10.1
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.0
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.1.0 locally built with this PR
Appcelerator Studio, build: 4.8.1.201612050850
Xcode 8.3.2
Android device 6.0.1
iOS Device 10.3

On iOS device, the background of the Title is red as expected. On the Android device it is black. Per the ticket, it should be red.

[jquick-axway]

Your code change in the "else" statement here no longer updates the "data" argument. It's making changes to a temporary "newData" local and then throwing it away.

[frankieandone]

updated.

updated.

[jquick-axway]

CR: Pass

[ssjsamir]

Master: #8670

Verified FR - Was able to see the red background on a ListItem as stated in the description.

Test steps

• Build the SDK using this PR
• Created a titanium application
• Pasted the code in in the application from the description
• Ran the program
• Saw red background on a ListItem

Test environment
Appcelerator Command-Line Interface, version 6.2.1
Google Nexus 6P (7.1.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850