Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24662] Bump to node-titanium-sdk 0.2.2 to get fix for minification using babili #9023

Merged
merged 3 commits into from May 6, 2017

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented May 5, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-24662

Description:

  • need to explicitly specify path to babili in node_modules using require, otherwise babel looked in user's project for it (when minifying user JS)

@hansemannn
Copy link
Collaborator

LGTM

@mukherjee2 mukherjee2 self-requested a review May 5, 2017 23:20
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes FR with this environment:
Node Version: 6.10.1
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.0
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0 PR/9023
XCode 8.3.2

Built with this PR, and project built successfully.

@mukherjee2
Copy link
Contributor

@sgtcoolguy FR passed, but "Merge" button is grayed out, and I am unable to merge. What do I need to do?

@cb1kenobi
Copy link
Contributor

@mukherjee2 The Jenkins job took a dump while fetching the git repo. According to the job log, it appears the problem is due to https://confluence.atlassian.com/stashkb/git-clone-fails-error-rpc-failed-result-56-http-code-200-693897332.html (bad network). Get a better network.

@mukherjee2
Copy link
Contributor

@cb1kenobi @sgtcoolguy @hansemannn I tried the manual method to merge and it still fails:
To https://github.com/appcelerator/titanium_mobile.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/appcelerator/titanium_mobile.git'

I'm on a network that's running at 150 Mb/s, so I don't think it's a network problem. It seems I don't have the right access or something. Can someone just merge it for me? I don't have issues with other PR's, just this one. I am confirming that FR did pass. Thanks.

@hansemannn hansemannn merged commit b450f0c into tidev:master May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants