New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24664] Update to Android support library 25.3.1 #9027
Conversation
android/modules/cardview/.classpath
Outdated
@@ -5,6 +5,6 @@ | |||
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.DEPENDENCIES"/> | |||
<classpathentry kind="src" path="src"/> | |||
<classpathentry kind="src" path="gen"/> | |||
<classpathentry exported="true" kind="lib" path="lib/cardview-v7-23.4.0.jar"/> | |||
<classpathentry exported="true" kind="lib" path="lib/cardview-v7-23.0.1.jar"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From 23.4.0 to 23.0.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's from reverting 80b4302, .classpath
aren't used anymore. They are left-overs from Eclipse.
Also, Jenkins is failing due to Android SDK 25 not being installed.
@@ -5,9 +5,7 @@ | |||
<classpathentry kind="con" path="com.android.ide.eclipse.adt.ANDROID_FRAMEWORK"/> | |||
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.LIBRARIES"/> | |||
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.DEPENDENCIES"/> | |||
<classpathentry exported="true" kind="lib" path="lib/android-support-annotations.jar"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not even sure if this files is used but we should at least keep it up to date for the sake of consistency (or delete them if they are not used?). The annotations support library is still there along with all the other new support libraries.
Edit: Just saw your other comment, so then we should delete them i guess.
@janvennemann Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
Approved!
e35d0d3
to
7fb5090
Compare
@janvennemann I updated this PR to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
@janvennemann , But when I build with 6.2.0 SDK it fails to dexer:
Am I missing something here ? |
FR Passed. Used the test steps here : https://jira.appcelerator.org/browse/TIMOB-24446?focusedCommentId=419942&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-419942 Studio Ver: 4.9.1.201707200100 |
25.3.1
23
->25
JIRA Ticket