Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24664] Update to Android support library 25.3.1 #9027

Merged
merged 6 commits into from Jul 21, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented May 8, 2017

  • Update Android support libraries to 25.3.1
  • Set build target API from 23 -> 25

JIRA Ticket

@@ -5,6 +5,6 @@
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.DEPENDENCIES"/>
<classpathentry kind="src" path="src"/>
<classpathentry kind="src" path="gen"/>
<classpathentry exported="true" kind="lib" path="lib/cardview-v7-23.4.0.jar"/>
<classpathentry exported="true" kind="lib" path="lib/cardview-v7-23.0.1.jar"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 23.4.0 to 23.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's from reverting 80b4302, .classpath aren't used anymore. They are left-overs from Eclipse.

Also, Jenkins is failing due to Android SDK 25 not being installed.

@@ -5,9 +5,7 @@
<classpathentry kind="con" path="com.android.ide.eclipse.adt.ANDROID_FRAMEWORK"/>
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.LIBRARIES"/>
<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.DEPENDENCIES"/>
<classpathentry exported="true" kind="lib" path="lib/android-support-annotations.jar"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even sure if this files is used but we should at least keep it up to date for the sake of consistency (or delete them if they are not used?). The annotations support library is still there along with all the other new support libraries.

Edit: Just saw your other comment, so then we should delete them i guess.

@garymathews
Copy link
Contributor Author

@janvennemann Updated .classpath dependencies

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Approved!

@garymathews
Copy link
Contributor Author

@janvennemann I updated this PR to add the android.support.design library

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@lokeshchdhry
Copy link
Contributor

@janvennemann ,
I followed the steps you mentioned in https://jira.appcelerator.org/browse/TIMOB-24446?focusedCommentId=419942&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-419942

But when I build with 6.2.0 SDK it fails to dexer:

[ERROR] :  Failed to run dexer:

[ERROR] :  

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/package-info;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BaselineLayout;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationAnimationHelperBase;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationAnimationHelperIcs;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationItemView;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationMenu;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationMenuView;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationMenuView$1;

[ERROR] :  Uncaught translation error: java.lang.IllegalArgumentException: already added: Landroid/support/design/internal/BottomNavigationPresenter;

[ERROR] :  

[ERROR] :  UNEXPECTED TOP-LEVEL EXCEPTION:

[ERROR] :  java.lang.RuntimeException: Translation has been interrupted

[ERROR] :  at com.android.dx.command.dexer.Main.processAllFiles(Main.java:615)

[ERROR] :  at com.android.dx.command.dexer.Main.runMultiDex(Main.java:368)

[ERROR] :  at com.android.dx.command.dexer.Main.runDx(Main.java:289)

[ERROR] :  at com.android.dx.command.dexer.Main.main(Main.java:247)

[ERROR] :  at com.android.dx.command.Main.main(Main.java:94)

[ERROR] :  Caused by: java.lang.InterruptedException: Too many errors

[ERROR] :  at com.android.dx.command.dexer.Main.processAllFiles(Main.java:607)

[ERROR] :  ... 4 more

Am I missing something here ?

@lokeshchdhry
Copy link
Contributor

FR Passed.

Used the test steps here : https://jira.appcelerator.org/browse/TIMOB-24446?focusedCommentId=419942&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-419942

Studio Ver: 4.9.1.201707200100
SDK Ver: 6.2.0.v20170720154351 from Jenkins in PR
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.2
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: Android 6.0, Android 7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants