Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-20156] iOS: Fix "typedText" for remote notifications #9033

Merged
merged 2 commits into from May 24, 2017
Merged

[TIMOB-20156] iOS: Fix "typedText" for remote notifications #9033

merged 2 commits into from May 24, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.2.0 milestone May 8, 2017
@hansemannn hansemannn mentioned this pull request May 8, 2017
Closed
vijaysingh-axway
vijaysingh-axway approved these changes May 22, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR and CR passed.

@htbryant94 htbryant94 self-requested a review May 22, 2017 12:40
htbryant94
htbryant94 approved these changes May 24, 2017
View reviewed changes
Copy link

@htbryant94 htbryant94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Using the following test steps, typedText was properly returned with the use of remote notifications:

  1. run test code, click 'Send Notification'.
  2. Background the app
  3. Send a push notification from arrowDB application with the "ok" channel
  4. Make sure the 'Category' field is "INVITE_CATEGORY"
  5. Swipe down on the banner alert and it will let you enter text
    put whatever you want and push send
  6. Check console for typedText property

@htbryant94 htbryant94 merged commit 42c1b5a into tidev:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htbryant94 htbryant94 htbryant94 approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

@ewieberappc ewieberappc Awaiting requested review from ewieberappc

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @htbryant94 @vijaysingh-axway