Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24667] Android: Fix LOWER_THAN_JELLYBEAN condition for HW-acceleration #9037

Merged
merged 5 commits into from May 17, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented May 9, 2017

  • Fix LOWER_THAN_JELLYBEAN condition to disable hardware acceleration for < API 17
TEST CASE
var win = Ti.UI.createWindow({
        backgroundColor: 'white'
    }),
    view = Ti.UI.createView({
        width: 100,
        height: 100,
        borderWidth: 3,
        borderRadius: 50,
        borderColor: 'red',
        backgroundColor: 'pink'
    });

win.add(view);
win.open();
  • Should display a circle with red border - test on Android 4.1 4.2 4.3 and 5.0

JIRA Ticket

@garymathews garymathews added this to the 6.2.0 milestone May 9, 2017
@garymathews garymathews requested a review from ypbnv May 9, 2017 14:14
@hansemannn
Copy link
Collaborator

@garymathews Looks good! Can we get a 6.1.0 backport for this if @eric34 agrees?

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR passed.

Adding a borderRadius on a view clips the backgroundColor as expected.

Studio Ver: 4.9.0.201704240654
SDK Ver: 6.2.0.v20170509154446
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.2
Appc NPM: 4.2.9
Appc CLI: 6.2.0
Ti CLI Ver: 5.0.12
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Emulator: Android 4.4.2, 4.2.2, 6.0

@garymathews garymathews merged commit 166b44b into tidev:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants