Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20024] iOS: Expose value, loginValue, passwordValue to AlertDialog #9046

Merged
merged 2 commits into from May 11, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 6.2.0 milestone May 10, 2017
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@sgtcoolguy
Copy link
Contributor

unit tests for these properties?

@mukherjee2 mukherjee2 self-requested a review May 11, 2017 16:53
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR with this environment:
Node Version: 6.10.1
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.0
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0 from this PR
Appcelerator Studio, build: 4.8.1.201612050850
Xcode 8.3.2

I built an iOS app to device using Han's testcase. I pressed on both buttons, and the forms were prefilled. I found that I had a choice to either edit the data in fields or I can hit the "OK" button if I accepted the pre-filled data.

@mukherjee2 mukherjee2 merged commit 6b41ae7 into tidev:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants