[TIMOB-24680] (6_1_X) Fixed list of valid provisioning profiles for the given… #9056
Conversation
… build target which is used to validate watch extension provisioning profile uuids.
| } | ||
| }) | ||
| .shift(); | ||
| } |
There was a problem hiding this comment.
We use that method too often. Please add this helper to our utils instead of pasting it to every usage. EDIT: I thought it was around more places, but actually just the one you replaced, so I guess we are fine here.
We also may want to move the app-targets to string-constants instead of compare to a hardcoded string. For example, dist-adhoc and dist-appstore are used 21 times, device is used 28 times. Something behind the scope of this ticket, but may be a good improvement.
There was a problem hiding this comment.
Great idea for the next overhaul.
hansemannn
changed the title
|
@htbryant94 Wait a second, should this go into 6.1.1? Because you just merged into 6_1_X, not master. The ticket says 6.2.0, however, I'd be fine for a 6.1.1 if @eric34 approves. |
|
@hansemannn I asked @eric34 whether to merge the fix into the 6_1_X branch as well as the master, and was confirmed to do so. It would be good to get a second approval just in case, however I do not see any reason why it shouldn't go into 6.1.1 |
[TIMOB-24680] Fixed list of valid provisioning profiles for the given build target which is used to validate watch extension provisioning profile uuids.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24680